* [PATCH] tracing: fix mismatched comment in __string_len
@ 2021-12-22 11:00 Geliang Tang
2021-12-24 13:48 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2021-12-22 11:00 UTC (permalink / raw)
To: Steven Rostedt (VMware), Masami Hiramatsu, Chuck Lever
Cc: Geliang Tang, linux-kernel
Here __assign_str_len() should be used for the __string_len type, instead
of __assign_str().
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
samples/trace_events/trace-events-sample.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
index 5ab74fc9a2df..cbbbb83beced 100644
--- a/samples/trace_events/trace-events-sample.h
+++ b/samples/trace_events/trace-events-sample.h
@@ -155,7 +155,7 @@
*
* To assign this string, use the helper macro __assign_str_len().
*
- * __assign_str(foo, bar, len);
+ * __assign_str_len(foo, bar, len);
*
* Then len + 1 is allocated to the ring buffer, and a nul terminating
* byte is added. This is similar to:
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: fix mismatched comment in __string_len
2021-12-22 11:00 [PATCH] tracing: fix mismatched comment in __string_len Geliang Tang
@ 2021-12-24 13:48 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2021-12-24 13:48 UTC (permalink / raw)
To: Geliang Tang; +Cc: Steven Rostedt (VMware), Chuck Lever, linux-kernel
On Wed, 22 Dec 2021 19:00:25 +0800
Geliang Tang <geliang.tang@suse.com> wrote:
> Here __assign_str_len() should be used for the __string_len type, instead
> of __assign_str().
>
Yeah, the comment in the above line is correct :)
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
> samples/trace_events/trace-events-sample.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
> index 5ab74fc9a2df..cbbbb83beced 100644
> --- a/samples/trace_events/trace-events-sample.h
> +++ b/samples/trace_events/trace-events-sample.h
> @@ -155,7 +155,7 @@
> *
> * To assign this string, use the helper macro __assign_str_len().
> *
> - * __assign_str(foo, bar, len);
> + * __assign_str_len(foo, bar, len);
> *
> * Then len + 1 is allocated to the ring buffer, and a nul terminating
> * byte is added. This is similar to:
> --
> 2.31.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-24 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-22 11:00 [PATCH] tracing: fix mismatched comment in __string_len Geliang Tang
2021-12-24 13:48 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox