The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] staging: r8188eu: remove GET_CVID_ROM_VERSION
@ 2021-12-26 18:42 Michael Straube
  2021-12-28  8:54 ` Michael Straube
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Straube @ 2021-12-26 18:42 UTC (permalink / raw)
  To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube

The macro GET_CVID_ROM_VERSION is not used. Remove it.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/include/HalVerDef.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/r8188eu/include/HalVerDef.h b/drivers/staging/r8188eu/include/HalVerDef.h
index 1d96657e6a98..62b94c993f0d 100644
--- a/drivers/staging/r8188eu/include/HalVerDef.h
+++ b/drivers/staging/r8188eu/include/HalVerDef.h
@@ -35,7 +35,6 @@ struct HAL_VERSION {
 #define GET_CVID_CHIP_TYPE(version)	(((version).ChipType))
 #define GET_CVID_MANUFACTUER(version)	(((version).VendorType))
 #define GET_CVID_CUT_VERSION(version)	(((version).CUTVersion))
-#define GET_CVID_ROM_VERSION(version)	(((version).ROMVer) & ROM_VERSION_MASK)
 
 /* Common Macro. -- */
 /* HAL_VERSION VersionID */
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: r8188eu: remove GET_CVID_ROM_VERSION
  2021-12-26 18:42 [PATCH] staging: r8188eu: remove GET_CVID_ROM_VERSION Michael Straube
@ 2021-12-28  8:54 ` Michael Straube
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Straube @ 2021-12-28  8:54 UTC (permalink / raw)
  To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel

On 12/26/21 19:42, Michael Straube wrote:
> The macro GET_CVID_ROM_VERSION is not used. Remove it.
> 
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
>   drivers/staging/r8188eu/include/HalVerDef.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/include/HalVerDef.h b/drivers/staging/r8188eu/include/HalVerDef.h
> index 1d96657e6a98..62b94c993f0d 100644
> --- a/drivers/staging/r8188eu/include/HalVerDef.h
> +++ b/drivers/staging/r8188eu/include/HalVerDef.h
> @@ -35,7 +35,6 @@ struct HAL_VERSION {
>   #define GET_CVID_CHIP_TYPE(version)	(((version).ChipType))
>   #define GET_CVID_MANUFACTUER(version)	(((version).VendorType))
>   #define GET_CVID_CUT_VERSION(version)	(((version).CUTVersion))
> -#define GET_CVID_ROM_VERSION(version)	(((version).ROMVer) & ROM_VERSION_MASK)
>   
>   /* Common Macro. -- */
>   /* HAL_VERSION VersionID */

This patch is outdated, please drop it.
I'll resend it as part of a series.

Thanks,
Michael

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-28  8:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-26 18:42 [PATCH] staging: r8188eu: remove GET_CVID_ROM_VERSION Michael Straube
2021-12-28  8:54 ` Michael Straube

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox