* [PATCH] drm/bridge: Fix free wrong object in sii8620_init_rcp_input_dev
@ 2021-12-27 9:25 Miaoqian Lin
2022-01-04 13:13 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Miaoqian Lin @ 2021-12-27 9:25 UTC (permalink / raw)
Cc: linmq006, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Sean Young, Mauro Carvalho Chehab, Maciej Purski,
dri-devel, linux-kernel
rc_dev is allocated by rc_allocate_device(), and doesn't assigned to
ctx->rc_dev before calling rc_free_device(ctx->rc_dev).
So it should call rc_free_device(rc_dev);
Fixes: e25f1f7 ("drm/bridge/sii8620: add remote control support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
index 843265d7f1b1..ec7745c31da0 100644
--- a/drivers/gpu/drm/bridge/sil-sii8620.c
+++ b/drivers/gpu/drm/bridge/sil-sii8620.c
@@ -2120,7 +2120,7 @@ static void sii8620_init_rcp_input_dev(struct sii8620 *ctx)
if (ret) {
dev_err(ctx->dev, "Failed to register RC device\n");
ctx->error = ret;
- rc_free_device(ctx->rc_dev);
+ rc_free_device(rc_dev);
return;
}
ctx->rc_dev = rc_dev;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/bridge: Fix free wrong object in sii8620_init_rcp_input_dev
2021-12-27 9:25 [PATCH] drm/bridge: Fix free wrong object in sii8620_init_rcp_input_dev Miaoqian Lin
@ 2022-01-04 13:13 ` Robert Foss
2022-01-04 13:15 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2022-01-04 13:13 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Sean Young,
Mauro Carvalho Chehab, Maciej Purski, dri-devel, linux-kernel
On Mon, 27 Dec 2021 at 10:25, Miaoqian Lin <linmq006@gmail.com> wrote:
>
> rc_dev is allocated by rc_allocate_device(), and doesn't assigned to
> ctx->rc_dev before calling rc_free_device(ctx->rc_dev).
> So it should call rc_free_device(rc_dev);
>
> Fixes: e25f1f7 ("drm/bridge/sii8620: add remote control support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
> index 843265d7f1b1..ec7745c31da0 100644
> --- a/drivers/gpu/drm/bridge/sil-sii8620.c
> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c
> @@ -2120,7 +2120,7 @@ static void sii8620_init_rcp_input_dev(struct sii8620 *ctx)
> if (ret) {
> dev_err(ctx->dev, "Failed to register RC device\n");
> ctx->error = ret;
> - rc_free_device(ctx->rc_dev);
> + rc_free_device(rc_dev);
> return;
> }
> ctx->rc_dev = rc_dev;
> --
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/bridge: Fix free wrong object in sii8620_init_rcp_input_dev
2022-01-04 13:13 ` Robert Foss
@ 2022-01-04 13:15 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-01-04 13:15 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Sean Young,
Mauro Carvalho Chehab, Maciej Purski, dri-devel, linux-kernel
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-04 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-27 9:25 [PATCH] drm/bridge: Fix free wrong object in sii8620_init_rcp_input_dev Miaoqian Lin
2022-01-04 13:13 ` Robert Foss
2022-01-04 13:15 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox