From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"William Breathitt Gray" <vilhelm.gray@gmail.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Lars-Peter Clausen <lars@metafoo.de>,
kernel@pengutronix.de,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/23] counter: Provide alternative counter registration functions
Date: Thu, 6 Jan 2022 13:53:31 +0300 [thread overview]
Message-ID: <202112290340.PMwi47LV-lkp@intel.com> (raw)
In-Reply-To: <20211227094526.698714-14-u.kleine-koenig@pengutronix.de>
Hi "Uwe,
url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/counter-cleanups-and-device-lifetime-fixes/20211227-174815
base: a7904a538933c525096ca2ccde1e60d0ee62c08e
config: i386-randconfig-m021-20211227 (https://download.01.org/0day-ci/archive/20211229/202112290340.PMwi47LV-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/counter/counter-core.c:175 counter_alloc() error: uninitialized symbol 'id'.
vim +/id +175 drivers/counter/counter-core.c
250e0e3d91caea Uwe Kleine-König 2021-12-27 144 struct counter_device *counter_alloc(size_t sizeof_priv)
250e0e3d91caea Uwe Kleine-König 2021-12-27 145 {
250e0e3d91caea Uwe Kleine-König 2021-12-27 146 struct counter_device_allochelper *ch;
250e0e3d91caea Uwe Kleine-König 2021-12-27 147 struct counter_device *counter;
250e0e3d91caea Uwe Kleine-König 2021-12-27 148 struct device *dev;
250e0e3d91caea Uwe Kleine-König 2021-12-27 149 int id, err;
250e0e3d91caea Uwe Kleine-König 2021-12-27 150
250e0e3d91caea Uwe Kleine-König 2021-12-27 151 ch = kzalloc(sizeof(*ch) + sizeof_priv, GFP_KERNEL);
250e0e3d91caea Uwe Kleine-König 2021-12-27 152 if (!ch) {
250e0e3d91caea Uwe Kleine-König 2021-12-27 153 err = -ENOMEM;
250e0e3d91caea Uwe Kleine-König 2021-12-27 154 goto err_alloc_ch;
250e0e3d91caea Uwe Kleine-König 2021-12-27 155 }
250e0e3d91caea Uwe Kleine-König 2021-12-27 156
250e0e3d91caea Uwe Kleine-König 2021-12-27 157 counter = &ch->counter;
250e0e3d91caea Uwe Kleine-König 2021-12-27 158 dev = &counter->dev;
250e0e3d91caea Uwe Kleine-König 2021-12-27 159
250e0e3d91caea Uwe Kleine-König 2021-12-27 160 /* Acquire unique ID */
250e0e3d91caea Uwe Kleine-König 2021-12-27 161 err = ida_alloc(&counter_ida, GFP_KERNEL);
250e0e3d91caea Uwe Kleine-König 2021-12-27 162 if (err < 0) {
250e0e3d91caea Uwe Kleine-König 2021-12-27 163 goto err_ida_alloc;
250e0e3d91caea Uwe Kleine-König 2021-12-27 164 }
250e0e3d91caea Uwe Kleine-König 2021-12-27 165 dev->id = err;
250e0e3d91caea Uwe Kleine-König 2021-12-27 166
250e0e3d91caea Uwe Kleine-König 2021-12-27 167 err = counter_chrdev_add(counter);
250e0e3d91caea Uwe Kleine-König 2021-12-27 168 if (err < 0)
250e0e3d91caea Uwe Kleine-König 2021-12-27 169 goto err_chrdev_add;
250e0e3d91caea Uwe Kleine-König 2021-12-27 170
250e0e3d91caea Uwe Kleine-König 2021-12-27 171 device_initialize(dev);
250e0e3d91caea Uwe Kleine-König 2021-12-27 172 /* Configure device structure for Counter */
250e0e3d91caea Uwe Kleine-König 2021-12-27 173 dev->type = &counter_device_type;
250e0e3d91caea Uwe Kleine-König 2021-12-27 174 dev->bus = &counter_bus_type;
250e0e3d91caea Uwe Kleine-König 2021-12-27 @175 dev->devt = MKDEV(MAJOR(counter_devt), id);
"id" is uninitialized. Should this be "dev->id"?
250e0e3d91caea Uwe Kleine-König 2021-12-27 176
250e0e3d91caea Uwe Kleine-König 2021-12-27 177 mutex_init(&counter->ops_exist_lock);
250e0e3d91caea Uwe Kleine-König 2021-12-27 178
250e0e3d91caea Uwe Kleine-König 2021-12-27 179 return counter;
250e0e3d91caea Uwe Kleine-König 2021-12-27 180
250e0e3d91caea Uwe Kleine-König 2021-12-27 181 err_chrdev_add:
250e0e3d91caea Uwe Kleine-König 2021-12-27 182
250e0e3d91caea Uwe Kleine-König 2021-12-27 183 ida_free(&counter_ida, dev->id);
250e0e3d91caea Uwe Kleine-König 2021-12-27 184 err_ida_alloc:
250e0e3d91caea Uwe Kleine-König 2021-12-27 185
250e0e3d91caea Uwe Kleine-König 2021-12-27 186 kfree(ch);
250e0e3d91caea Uwe Kleine-König 2021-12-27 187 err_alloc_ch:
250e0e3d91caea Uwe Kleine-König 2021-12-27 188
250e0e3d91caea Uwe Kleine-König 2021-12-27 189 return ERR_PTR(err);
250e0e3d91caea Uwe Kleine-König 2021-12-27 190 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-01-06 10:54 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 9:45 [PATCH v2 00/23] counter: cleanups and device lifetime fixes Uwe Kleine-König
2021-12-27 9:45 ` [PATCH v2 01/23] counter: Use container_of instead of drvdata to track counter_device Uwe Kleine-König
2021-12-28 17:14 ` Jonathan Cameron
2021-12-29 6:38 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 02/23] counter: ftm-quaddec: Drop unused platform_set_drvdata() Uwe Kleine-König
2021-12-28 17:37 ` Jonathan Cameron
2021-12-29 6:42 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 03/23] counter: microchip-tcb-capture: " Uwe Kleine-König
2021-12-28 17:38 ` Jonathan Cameron
2021-12-29 6:44 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 04/23] counter: Provide a wrapper to access device private data Uwe Kleine-König
2021-12-27 11:02 ` Greg Kroah-Hartman
2021-12-27 11:34 ` Lars-Peter Clausen
2021-12-27 11:52 ` Greg Kroah-Hartman
2021-12-27 12:28 ` Lars-Peter Clausen
2021-12-28 18:01 ` Jonathan Cameron
2021-12-29 6:47 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 05/23] counter: 104-quad-8: Convert to counter_priv() wrapper Uwe Kleine-König
2021-12-28 18:02 ` Jonathan Cameron
2021-12-29 11:11 ` Uwe Kleine-König
2021-12-29 7:27 ` William Breathitt Gray
2021-12-29 11:15 ` Uwe Kleine-König
2021-12-29 22:40 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 06/23] counter: interrupt-cnt: " Uwe Kleine-König
2021-12-28 18:04 ` Jonathan Cameron
2021-12-29 7:34 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 07/23] counter: microchip-tcb-capture: " Uwe Kleine-König
2021-12-28 18:05 ` Jonathan Cameron
2021-12-29 7:35 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 08/23] counter: intel-qep: " Uwe Kleine-König
2021-12-28 18:06 ` Jonathan Cameron
2021-12-29 7:35 ` William Breathitt Gray
2021-12-29 12:43 ` Jarkko Nikula
2021-12-27 9:45 ` [PATCH v2 09/23] counter: ftm-quaddec: " Uwe Kleine-König
2021-12-28 18:07 ` Jonathan Cameron
2021-12-29 7:36 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 10/23] counter: ti-eqep: " Uwe Kleine-König
2021-12-28 18:07 ` Jonathan Cameron
2021-12-29 7:45 ` William Breathitt Gray
2021-12-29 11:19 ` Uwe Kleine-König
2021-12-27 9:45 ` [PATCH v2 11/23] counter: stm32-lptimer-cnt: " Uwe Kleine-König
2021-12-28 18:08 ` Jonathan Cameron
2021-12-29 7:48 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 12/23] counter: stm32-timer-cnt: " Uwe Kleine-König
2021-12-28 18:08 ` Jonathan Cameron
2021-12-29 7:48 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 13/23] counter: Provide alternative counter registration functions Uwe Kleine-König
2021-12-27 12:16 ` Lars-Peter Clausen
2021-12-28 11:22 ` Uwe Kleine-König
2021-12-27 12:18 ` kernel test robot
2021-12-28 18:00 ` Jonathan Cameron
2021-12-29 11:27 ` Uwe Kleine-König
2021-12-29 12:07 ` Uwe Kleine-König
2021-12-29 13:49 ` Jarkko Nikula
2021-12-29 15:47 ` Uwe Kleine-König
2021-12-29 8:13 ` William Breathitt Gray
2022-01-06 10:53 ` Dan Carpenter [this message]
2021-12-27 9:45 ` [PATCH v2 14/23] counter: Update documentation for new " Uwe Kleine-König
2021-12-28 18:12 ` Jonathan Cameron
2021-12-29 8:19 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 15/23] counter: 104-quad-8: Convert to new counter registration Uwe Kleine-König
2021-12-27 12:19 ` Lars-Peter Clausen
2021-12-28 11:06 ` Uwe Kleine-König
2021-12-28 18:17 ` Jonathan Cameron
2021-12-29 8:24 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 16/23] counter: interrupt-cnt: " Uwe Kleine-König
2021-12-27 10:59 ` Greg Kroah-Hartman
2021-12-27 11:21 ` Lars-Peter Clausen
2021-12-27 11:34 ` Greg Kroah-Hartman
2021-12-27 11:44 ` Lars-Peter Clausen
2021-12-27 21:09 ` Uwe Kleine-König
2021-12-28 18:18 ` Jonathan Cameron
2021-12-29 8:27 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 17/23] counter: intel-qep: " Uwe Kleine-König
2021-12-27 15:02 ` Jarkko Nikula
2021-12-28 10:56 ` Uwe Kleine-König
2021-12-29 12:42 ` Jarkko Nikula
2021-12-28 18:20 ` Jonathan Cameron
2021-12-29 8:29 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 18/23] counter: ftm-quaddec: " Uwe Kleine-König
2021-12-28 18:23 ` Jonathan Cameron
2021-12-29 8:33 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 19/23] counter: microchip-tcb-capture: " Uwe Kleine-König
2021-12-28 18:24 ` Jonathan Cameron
2021-12-29 8:36 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 20/23] counter: stm32-timer-cnt: " Uwe Kleine-König
2021-12-28 18:25 ` Jonathan Cameron
2021-12-29 8:37 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 21/23] counter: stm32-lptimer-cnt: " Uwe Kleine-König
2021-12-28 18:26 ` Jonathan Cameron
2021-12-29 8:39 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 22/23] counter: ti-eqep: " Uwe Kleine-König
2021-12-28 18:29 ` Jonathan Cameron
2021-12-29 8:41 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 23/23] counter: remove old and now unused registration API Uwe Kleine-König
2021-12-28 18:31 ` Jonathan Cameron
2021-12-29 8:43 ` William Breathitt Gray
2021-12-27 12:25 ` [PATCH v2 00/23] counter: cleanups and device lifetime fixes Lars-Peter Clausen
2021-12-28 17:35 ` Jonathan Cameron
2021-12-29 8:49 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112290340.PMwi47LV-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox