The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Zizhuang Deng <sunsetdzz@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tianjia.zhang@linux.alibaba.com, Zizhuang Deng <sunsetdzz@gmail.com>
Subject: [PATCH] lib/mpi: add the return value check of kcalloc
Date: Thu, 30 Dec 2021 10:51:59 +0800	[thread overview]
Message-ID: <20211230025159.460218-1-sunsetdzz@gmail.com> (raw)

Add the return value check of kcalloc to avoid potential
NULL ptr dereference.

Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
---
 lib/mpi/mpi-mod.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
index 47bc59edd4ff..6fd6900f0798 100644
--- a/lib/mpi/mpi-mod.c
+++ b/lib/mpi/mpi-mod.c
@@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
 	mpi_normalize(m);
 	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
 
+	if (!ctx) {
+		return NULL;
+	}
+
 	if (copy) {
 		ctx->m = mpi_copy(m);
 		ctx->m_copied = 1;
-- 
2.25.1


             reply	other threads:[~2021-12-30  2:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30  2:51 Zizhuang Deng [this message]
2021-12-30  6:41 ` [PATCH] lib/mpi: add the return value check of kcalloc Tianjia Zhang
2021-12-30  6:45 ` Tianjia Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211230025159.460218-1-sunsetdzz@gmail.com \
    --to=sunsetdzz@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tianjia.zhang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox