* [PATCH] lib/mpi: add the return value check of kcalloc
@ 2021-12-30 2:51 Zizhuang Deng
2021-12-30 6:41 ` Tianjia Zhang
2021-12-30 6:45 ` Tianjia Zhang
0 siblings, 2 replies; 3+ messages in thread
From: Zizhuang Deng @ 2021-12-30 2:51 UTC (permalink / raw)
To: linux-kernel; +Cc: tianjia.zhang, Zizhuang Deng
Add the return value check of kcalloc to avoid potential
NULL ptr dereference.
Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
---
lib/mpi/mpi-mod.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
index 47bc59edd4ff..6fd6900f0798 100644
--- a/lib/mpi/mpi-mod.c
+++ b/lib/mpi/mpi-mod.c
@@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
mpi_normalize(m);
ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
+ if (!ctx) {
+ return NULL;
+ }
+
if (copy) {
ctx->m = mpi_copy(m);
ctx->m_copied = 1;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/mpi: add the return value check of kcalloc
2021-12-30 2:51 [PATCH] lib/mpi: add the return value check of kcalloc Zizhuang Deng
@ 2021-12-30 6:41 ` Tianjia Zhang
2021-12-30 6:45 ` Tianjia Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Tianjia Zhang @ 2021-12-30 6:41 UTC (permalink / raw)
To: Zizhuang Deng, linux-kernel
Hi Zizhuang,
On 12/30/21 10:51 AM, Zizhuang Deng wrote:
> Add the return value check of kcalloc to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---
> lib/mpi/mpi-mod.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..6fd6900f0798 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
> mpi_normalize(m);
> ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
>
Remove this empty line.
> + if (!ctx) {
> + return NULL;
> + }
> +
> if (copy) {
> ctx->m = mpi_copy(m);
> ctx->m_copied = 1;
Thanks for pointing it out. Please send a copy to linux-crypto and
Herbert Xu.
Best regards,
Tianjia
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/mpi: add the return value check of kcalloc
2021-12-30 2:51 [PATCH] lib/mpi: add the return value check of kcalloc Zizhuang Deng
2021-12-30 6:41 ` Tianjia Zhang
@ 2021-12-30 6:45 ` Tianjia Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Tianjia Zhang @ 2021-12-30 6:45 UTC (permalink / raw)
To: Zizhuang Deng, linux-kernel
On 12/30/21 10:51 AM, Zizhuang Deng wrote:
> Add the return value check of kcalloc to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---
> lib/mpi/mpi-mod.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..6fd6900f0798 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
> mpi_normalize(m);
> ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
>
> + if (!ctx) {
> + return NULL;
> + }
> +
Delete the pair of curly braces, and just keep:
if (!ctx)
return NULL;
Thanks.
> if (copy) {
> ctx->m = mpi_copy(m);
> ctx->m_copied = 1;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-30 6:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-30 2:51 [PATCH] lib/mpi: add the return value check of kcalloc Zizhuang Deng
2021-12-30 6:41 ` Tianjia Zhang
2021-12-30 6:45 ` Tianjia Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox