linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN
@ 2021-12-30  7:32 Lukas Bulwahn
  0 siblings, 0 replies; only message in thread
From: Lukas Bulwahn @ 2021-12-30  7:32 UTC (permalink / raw)
  To: Jens Axboe, Tejun Heo, linux-block
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Commit cd006509b0a9 ("blk-iocost: account for IO size when testing
latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in
config BLK_CGROUP_IOCOST.

Hence, ./scripts/checkkconfigsymbols.py warns:

  BLK_RQ_IO_DATA_LEN
  Referencing files: block/Kconfig

Probably, this select is just some unintended left-over from an earlier
draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the
repository. So, drop this dead select to an undefined config.

Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
first submission:
https://lore.kernel.org/all/20211112093728.3237-1-lukas.bulwahn@gmail.com/

Patch is already acked by Tejun.
Jens, please pick this quick minor clean-up patch. 

 block/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/Kconfig b/block/Kconfig
index d5d4197b7ed2..80826e28d0d5 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -136,7 +136,6 @@ config BLK_CGROUP_FC_APPID
 config BLK_CGROUP_IOCOST
 	bool "Enable support for cost model based cgroup IO controller"
 	depends on BLK_CGROUP
-	select BLK_RQ_IO_DATA_LEN
 	select BLK_RQ_ALLOC_TIME
 	help
 	Enabling this option enables the .weight interface for cost
-- 
2.17.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-30  7:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-30  7:32 [PATCH RESEND] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN Lukas Bulwahn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).