* [PATCH] habanalabs: silence an uninitialized variable warning
@ 2022-01-11 7:16 Dan Carpenter
2022-01-23 14:39 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-01-11 7:16 UTC (permalink / raw)
To: Oded Gabbay
Cc: Arnd Bergmann, Greg Kroah-Hartman, Ofir Bitton, Yuri Nudelman,
farah kassabri, Alon Mizrahi, linux-kernel, kernel-janitors
Smatch warns that:
drivers/misc/habanalabs/common/command_buffer.c:471 hl_cb_ioctl()
error: uninitialized symbol 'device_va'.
Which is true, but harmless. Anyway, it's easy to silence this by
adding a error check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/misc/habanalabs/common/command_buffer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/habanalabs/common/command_buffer.c b/drivers/misc/habanalabs/common/command_buffer.c
index 3c0ae07a2d80..b9483a3cee91 100644
--- a/drivers/misc/habanalabs/common/command_buffer.c
+++ b/drivers/misc/habanalabs/common/command_buffer.c
@@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
args->in.flags,
&usage_cnt,
&device_va);
+ if (rc)
+ break;
memset(&args->out, 0, sizeof(args->out));
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] habanalabs: silence an uninitialized variable warning
2022-01-11 7:16 [PATCH] habanalabs: silence an uninitialized variable warning Dan Carpenter
@ 2022-01-23 14:39 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2022-01-23 14:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: Arnd Bergmann, Greg Kroah-Hartman, Ofir Bitton, Yuri Nudelman,
farah kassabri, Alon Mizrahi, Linux-Kernel@Vger. Kernel. Org,
kernel-janitors
On Tue, Jan 11, 2022 at 9:17 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Smatch warns that:
>
> drivers/misc/habanalabs/common/command_buffer.c:471 hl_cb_ioctl()
> error: uninitialized symbol 'device_va'.
>
> Which is true, but harmless. Anyway, it's easy to silence this by
> adding a error check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/misc/habanalabs/common/command_buffer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/common/command_buffer.c b/drivers/misc/habanalabs/common/command_buffer.c
> index 3c0ae07a2d80..b9483a3cee91 100644
> --- a/drivers/misc/habanalabs/common/command_buffer.c
> +++ b/drivers/misc/habanalabs/common/command_buffer.c
> @@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
> args->in.flags,
> &usage_cnt,
> &device_va);
> + if (rc)
> + break;
>
> memset(&args->out, 0, sizeof(args->out));
>
> --
> 2.20.1
>
Thanks!
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-23 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11 7:16 [PATCH] habanalabs: silence an uninitialized variable warning Dan Carpenter
2022-01-23 14:39 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox