* [PATCH 2/8] mailbox: qcom: Add support for SDX65 APCS IPC
@ 2022-02-14 6:55 Rohit Agarwal
2022-02-14 8:34 ` Manivannan Sadhasivam
0 siblings, 1 reply; 4+ messages in thread
From: Rohit Agarwal @ 2022-02-14 6:55 UTC (permalink / raw)
To: agross, bjorn.andersson, jassisinghbrar
Cc: linux-arm-msm, linux-kernel, Rohit Agarwal
In SDX65, the IPC bits are located in the APCS GCC block. Also, this block
can provide clock functionality. Hence, add support for IPC with correct
offset and name of the clock provider.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 9325d2a..3f8612c 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -53,6 +53,10 @@ static const struct qcom_apcs_ipc_data sdx55_apcs_data = {
.offset = 0x1008, .clk_name = "qcom-sdx55-acps-clk"
};
+static const struct qcom_apcs_ipc_data sdx65_apcs_data = {
+ .offset = 0x1008, .clk_name = "qcom-sdx65-acps-clk"
+};
+
static const struct regmap_config apcs_regmap_config = {
.reg_bits = 32,
.reg_stride = 4,
@@ -159,6 +163,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
{ .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
{ .compatible = "qcom,sm6115-apcs-hmss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
+ { .compatible = "qcom,sdx65-apcs-gcc", .data = &sdx65_apcs_data },
{}
};
MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/8] mailbox: qcom: Add support for SDX65 APCS IPC
2022-02-14 6:55 [PATCH 2/8] mailbox: qcom: Add support for SDX65 APCS IPC Rohit Agarwal
@ 2022-02-14 8:34 ` Manivannan Sadhasivam
2022-02-14 8:49 ` Manivannan Sadhasivam
0 siblings, 1 reply; 4+ messages in thread
From: Manivannan Sadhasivam @ 2022-02-14 8:34 UTC (permalink / raw)
To: Rohit Agarwal
Cc: agross, bjorn.andersson, jassisinghbrar, linux-arm-msm,
linux-kernel
On Mon, Feb 14, 2022 at 12:25:55PM +0530, Rohit Agarwal wrote:
> In SDX65, the IPC bits are located in the APCS GCC block. Also, this block
> can provide clock functionality. Hence, add support for IPC with correct
> offset and name of the clock provider.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 9325d2a..3f8612c 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -53,6 +53,10 @@ static const struct qcom_apcs_ipc_data sdx55_apcs_data = {
> .offset = 0x1008, .clk_name = "qcom-sdx55-acps-clk"
> };
>
> +static const struct qcom_apcs_ipc_data sdx65_apcs_data = {
> + .offset = 0x1008, .clk_name = "qcom-sdx65-acps-clk"
> +};
> +
> static const struct regmap_config apcs_regmap_config = {
> .reg_bits = 32,
> .reg_stride = 4,
> @@ -159,6 +163,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
> { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
> { .compatible = "qcom,sm6115-apcs-hmss-global", .data = &msm8994_apcs_data },
> { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
> + { .compatible = "qcom,sdx65-apcs-gcc", .data = &sdx65_apcs_data },
> {}
> };
> MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/8] mailbox: qcom: Add support for SDX65 APCS IPC
2022-02-14 8:34 ` Manivannan Sadhasivam
@ 2022-02-14 8:49 ` Manivannan Sadhasivam
2022-02-15 5:47 ` Rohit Agarwal
0 siblings, 1 reply; 4+ messages in thread
From: Manivannan Sadhasivam @ 2022-02-14 8:49 UTC (permalink / raw)
To: Rohit Agarwal
Cc: agross, bjorn.andersson, jassisinghbrar, linux-arm-msm,
linux-kernel
On Mon, Feb 14, 2022 at 02:04:14PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Feb 14, 2022 at 12:25:55PM +0530, Rohit Agarwal wrote:
> > In SDX65, the IPC bits are located in the APCS GCC block. Also, this block
> > can provide clock functionality. Hence, add support for IPC with correct
> > offset and name of the clock provider.
> >
> > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Thanks,
> Mani
>
> > ---
> > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> > index 9325d2a..3f8612c 100644
> > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> > @@ -53,6 +53,10 @@ static const struct qcom_apcs_ipc_data sdx55_apcs_data = {
> > .offset = 0x1008, .clk_name = "qcom-sdx55-acps-clk"
> > };
> >
> > +static const struct qcom_apcs_ipc_data sdx65_apcs_data = {
> > + .offset = 0x1008, .clk_name = "qcom-sdx65-acps-clk"
> > +};
> > +
After looking at patch 7/8, I think we should be able to reuse
"qcom-sdx55-acps-clk" for SDX65.
Thanks,
Mani
> > static const struct regmap_config apcs_regmap_config = {
> > .reg_bits = 32,
> > .reg_stride = 4,
> > @@ -159,6 +163,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
> > { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
> > { .compatible = "qcom,sm6115-apcs-hmss-global", .data = &msm8994_apcs_data },
> > { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
> > + { .compatible = "qcom,sdx65-apcs-gcc", .data = &sdx65_apcs_data },
> > {}
> > };
> > MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match);
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/8] mailbox: qcom: Add support for SDX65 APCS IPC
2022-02-14 8:49 ` Manivannan Sadhasivam
@ 2022-02-15 5:47 ` Rohit Agarwal
0 siblings, 0 replies; 4+ messages in thread
From: Rohit Agarwal @ 2022-02-15 5:47 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: agross, bjorn.andersson, jassisinghbrar, linux-arm-msm,
linux-kernel
On 2/14/2022 2:19 PM, Manivannan Sadhasivam wrote:
> On Mon, Feb 14, 2022 at 02:04:14PM +0530, Manivannan Sadhasivam wrote:
>> On Mon, Feb 14, 2022 at 12:25:55PM +0530, Rohit Agarwal wrote:
>>> In SDX65, the IPC bits are located in the APCS GCC block. Also, this block
>>> can provide clock functionality. Hence, add support for IPC with correct
>>> offset and name of the clock provider.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>
>> Thanks,
>> Mani
>>
>>> ---
>>> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>>> index 9325d2a..3f8612c 100644
>>> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>>> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>>> @@ -53,6 +53,10 @@ static const struct qcom_apcs_ipc_data sdx55_apcs_data = {
>>> .offset = 0x1008, .clk_name = "qcom-sdx55-acps-clk"
>>> };
>>>
>>> +static const struct qcom_apcs_ipc_data sdx65_apcs_data = {
>>> + .offset = 0x1008, .clk_name = "qcom-sdx65-acps-clk"
>>> +};
>>> +
> After looking at patch 7/8, I think we should be able to reuse
> "qcom-sdx55-acps-clk" for SDX65.
Yes. Will update the patch. Thanks
>
> Thanks,
> Mani
>>> static const struct regmap_config apcs_regmap_config = {
>>> .reg_bits = 32,
>>> .reg_stride = 4,
>>> @@ -159,6 +163,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
>>> { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
>>> { .compatible = "qcom,sm6115-apcs-hmss-global", .data = &msm8994_apcs_data },
>>> { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
>>> + { .compatible = "qcom,sdx65-apcs-gcc", .data = &sdx65_apcs_data },
>>> {}
>>> };
>>> MODULE_DEVICE_TABLE(of, qcom_apcs_ipc_of_match);
>>> --
>>> 2.7.4
>>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-15 5:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-14 6:55 [PATCH 2/8] mailbox: qcom: Add support for SDX65 APCS IPC Rohit Agarwal
2022-02-14 8:34 ` Manivannan Sadhasivam
2022-02-14 8:49 ` Manivannan Sadhasivam
2022-02-15 5:47 ` Rohit Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox