* [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout
@ 2022-02-09 15:39 Håkon Bugge
2022-02-13 11:56 ` Leon Romanovsky
2022-02-17 15:53 ` Jason Gunthorpe
0 siblings, 2 replies; 5+ messages in thread
From: Håkon Bugge @ 2022-02-09 15:39 UTC (permalink / raw)
To: Jason Gunthorpe, Leon Romanovsky; +Cc: linux-rdma, linux-kernel
XRC INI QPs should be able to adjust their local ACK timeout.
Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Suggested-by: Avneesh Pant <avneesh.pant@oracle.com>
---
v1 -> v2:
* Removed WARN_ON as suggested by Leon
---
drivers/infiniband/core/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 0f5f0d7..7adacd1 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout)
{
struct rdma_id_private *id_priv;
- if (id->qp_type != IB_QPT_RC)
+ if (id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_INI)
return -EINVAL;
id_priv = container_of(id, struct rdma_id_private, id);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout
2022-02-09 15:39 [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout Håkon Bugge
@ 2022-02-13 11:56 ` Leon Romanovsky
2022-02-17 11:29 ` Haakon Bugge
2022-02-17 15:53 ` Jason Gunthorpe
1 sibling, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2022-02-13 11:56 UTC (permalink / raw)
To: Håkon Bugge; +Cc: Jason Gunthorpe, linux-rdma, linux-kernel
On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote:
> XRC INI QPs should be able to adjust their local ACK timeout.
>
> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com>
>
> ---
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout
2022-02-13 11:56 ` Leon Romanovsky
@ 2022-02-17 11:29 ` Haakon Bugge
2022-02-17 15:36 ` Jason Gunthorpe
0 siblings, 1 reply; 5+ messages in thread
From: Haakon Bugge @ 2022-02-17 11:29 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Jason Gunthorpe, OFED mailing list, linux-kernel@vger.kernel.org
> On 13 Feb 2022, at 12:56, Leon Romanovsky <leon@kernel.org> wrote:
>
> On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote:
>> XRC INI QPs should be able to adjust their local ACK timeout.
>>
>> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
>> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
>> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com>
>>
>> ---
>>
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3?
Thxs, Håkon
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout
2022-02-17 11:29 ` Haakon Bugge
@ 2022-02-17 15:36 ` Jason Gunthorpe
0 siblings, 0 replies; 5+ messages in thread
From: Jason Gunthorpe @ 2022-02-17 15:36 UTC (permalink / raw)
To: Haakon Bugge
Cc: Leon Romanovsky, OFED mailing list, linux-kernel@vger.kernel.org
On Thu, Feb 17, 2022 at 11:29:41AM +0000, Haakon Bugge wrote:
>
>
> > On 13 Feb 2022, at 12:56, Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote:
> >> XRC INI QPs should be able to adjust their local ACK timeout.
> >>
> >> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
> >> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> >> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com>
> >>
> >>
> >
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
>
> Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3?
I will fix it
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout
2022-02-09 15:39 [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout Håkon Bugge
2022-02-13 11:56 ` Leon Romanovsky
@ 2022-02-17 15:53 ` Jason Gunthorpe
1 sibling, 0 replies; 5+ messages in thread
From: Jason Gunthorpe @ 2022-02-17 15:53 UTC (permalink / raw)
To: Håkon Bugge; +Cc: Leon Romanovsky, linux-rdma, linux-kernel
On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote:
> XRC INI QPs should be able to adjust their local ACK timeout.
>
> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>
> v1 -> v2:
> * Removed WARN_ON as suggested by Leon
> ---
> drivers/infiniband/core/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-17 15:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-09 15:39 [PATCH for-rc v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout Håkon Bugge
2022-02-13 11:56 ` Leon Romanovsky
2022-02-17 11:29 ` Haakon Bugge
2022-02-17 15:36 ` Jason Gunthorpe
2022-02-17 15:53 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox