* [PATCH 10/10] Constify comedi_lrange struct pointers
@ 2022-03-09 9:20 Hatim Muhammed
2022-03-09 12:24 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Hatim Muhammed @ 2022-03-09 9:20 UTC (permalink / raw)
To: linux-kernel; +Cc: greg, abbotti, hsweeten, Hatim Muhammed
From: Hatim Muhammed <hatimmohammed369@gmail.com>
Signed-off-by: Hatim Muhammed <hatimmohammed369@gmail.com>
---
drivers/comedi/drivers/jr3_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/comedi/drivers/jr3_pci.c b/drivers/comedi/drivers/jr3_pci.c
index 951c23fa0369..f2a750a9112c 100644
--- a/drivers/comedi/drivers/jr3_pci.c
+++ b/drivers/comedi/drivers/jr3_pci.c
@@ -90,8 +90,8 @@ struct jr3_pci_dev_private {
};
union jr3_pci_single_range {
- struct comedi_lrange l;
- char _reserved[offsetof(struct comedi_lrange, range[1])];
+ const struct comedi_lrange l;
+ char _reserved[offsetof(const struct comedi_lrange, range[1])];
};
enum jr3_pci_poll_state {
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 10/10] Constify comedi_lrange struct pointers
2022-03-09 9:20 [PATCH 10/10] Constify comedi_lrange struct pointers Hatim Muhammed
@ 2022-03-09 12:24 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2022-03-09 12:24 UTC (permalink / raw)
To: Hatim Muhammed, linux-kernel; +Cc: greg, hsweeten
On 09/03/2022 09:20, Hatim Muhammed wrote:
> From: Hatim Muhammed <hatimmohammed369@gmail.com>
>
> Signed-off-by: Hatim Muhammed <hatimmohammed369@gmail.com>
> ---
> drivers/comedi/drivers/jr3_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/comedi/drivers/jr3_pci.c b/drivers/comedi/drivers/jr3_pci.c
> index 951c23fa0369..f2a750a9112c 100644
> --- a/drivers/comedi/drivers/jr3_pci.c
> +++ b/drivers/comedi/drivers/jr3_pci.c
> @@ -90,8 +90,8 @@ struct jr3_pci_dev_private {
> };
>
> union jr3_pci_single_range {
> - struct comedi_lrange l;
> - char _reserved[offsetof(struct comedi_lrange, range[1])];
> + const struct comedi_lrange l;
> + char _reserved[offsetof(const struct comedi_lrange, range[1])];
> };
>
> enum jr3_pci_poll_state {
NAK. That really should not be const.
--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-09 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-09 9:20 [PATCH 10/10] Constify comedi_lrange struct pointers Hatim Muhammed
2022-03-09 12:24 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox