public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: stable@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: james.morse@arm.com, catalin.marinas@arm.com
Subject: [stable:PATCH v4.14.274 25/27] KVM: arm64: Allow SMCCC_ARCH_WORKAROUND_3 to be discovered and migrated
Date: Thu, 31 Mar 2022 19:33:58 +0100	[thread overview]
Message-ID: <20220331183400.73183-26-james.morse@arm.com> (raw)
In-Reply-To: <20220331183400.73183-1-james.morse@arm.com>

commit a5905d6af492ee6a4a2205f0d550b3f931b03d03 upstream.

KVM allows the guest to discover whether the ARCH_WORKAROUND SMCCC are
implemented, and to preserve that state during migration through its
firmware register interface.

Add the necessary boiler plate for SMCCC_ARCH_WORKAROUND_3.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
[ kvm code moved to virt/kvm/arm, removed fw regs ABI. Added 32bit stub ]
Signed-off-by: James Morse <james.morse@arm.com>
---
 arch/arm/include/asm/kvm_host.h   |  6 ++++++
 arch/arm64/include/asm/kvm_host.h |  5 +++++
 virt/kvm/arm/psci.c               | 12 ++++++++++++
 3 files changed, 23 insertions(+)

diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
index b60232639984..dbd9615b428c 100644
--- a/arch/arm/include/asm/kvm_host.h
+++ b/arch/arm/include/asm/kvm_host.h
@@ -26,6 +26,7 @@
 #include <asm/kvm_asm.h>
 #include <asm/kvm_mmio.h>
 #include <asm/fpstate.h>
+#include <asm/spectre.h>
 #include <kvm/arm_arch_timer.h>
 
 #define __KVM_HAVE_ARCH_INTC_INITIALIZED
@@ -324,4 +325,9 @@ static inline int kvm_arm_have_ssbd(void)
 	return KVM_SSBD_UNKNOWN;
 }
 
+static inline int kvm_arm_get_spectre_bhb_state(void)
+{
+	/* 32bit guests don't need firmware for this */
+	return SPECTRE_VULNERABLE; /* aka SMCCC_RET_NOT_SUPPORTED */
+}
 #endif /* __ARM_KVM_HOST_H__ */
diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
index 8d94404829f0..be82119ed24a 100644
--- a/arch/arm64/include/asm/kvm_host.h
+++ b/arch/arm64/include/asm/kvm_host.h
@@ -450,4 +450,9 @@ static inline int kvm_arm_have_ssbd(void)
 	}
 }
 
+static inline enum mitigation_state kvm_arm_get_spectre_bhb_state(void)
+{
+	return arm64_get_spectre_bhb_state();
+}
+
 #endif /* __ARM64_KVM_HOST_H__ */
diff --git a/virt/kvm/arm/psci.c b/virt/kvm/arm/psci.c
index c95ab4c5a475..129b755824e1 100644
--- a/virt/kvm/arm/psci.c
+++ b/virt/kvm/arm/psci.c
@@ -433,6 +433,18 @@ int kvm_hvc_call_handler(struct kvm_vcpu *vcpu)
 				break;
 			}
 			break;
+		case ARM_SMCCC_ARCH_WORKAROUND_3:
+			switch (kvm_arm_get_spectre_bhb_state()) {
+			case SPECTRE_VULNERABLE:
+				break;
+			case SPECTRE_MITIGATED:
+				val = SMCCC_RET_SUCCESS;
+				break;
+			case SPECTRE_UNAFFECTED:
+				val = SMCCC_ARCH_WORKAROUND_RET_UNAFFECTED;
+				break;
+			}
+			break;
 		}
 		break;
 	default:
-- 
2.30.2


  parent reply	other threads:[~2022-03-31 18:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 18:33 [stable:PATCH v4.14.274 00/27] arm64: Mitigate spectre style branch history side channels James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 01/27] arm64: arch_timer: Add workaround for ARM erratum 1188873 James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 02/27] arm64: arch_timer: avoid unused function warning James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 03/27] arm64: Add silicon-errata.txt entry for ARM erratum 1188873 James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 04/27] arm64: Make ARM64_ERRATUM_1188873 depend on COMPAT James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 05/27] arm64: Add part number for Neoverse N1 James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 06/27] arm64: Add part number for Arm Cortex-A77 James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 07/27] arm64: Add Neoverse-N2, Cortex-A710 CPU part definition James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 08/27] arm64: Add Cortex-X2 " James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 09/27] arm64: entry.S: Add ventry overflow sanity checks James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 10/27] arm64: entry: Make the trampoline cleanup optional James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 11/27] arm64: entry: Free up another register on kpti's tramp_exit path James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 12/27] arm64: entry: Move the trampoline data page before the text page James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 13/27] arm64: entry: Allow tramp_alias to access symbols after the 4K boundary James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 14/27] arm64: entry: Don't assume tramp_vectors is the start of the vectors James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 15/27] arm64: entry: Move trampoline macros out of ifdef'd section James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 16/27] arm64: entry: Make the kpti trampoline's kpti sequence optional James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 17/27] arm64: entry: Allow the trampoline text to occupy multiple pages James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 18/27] arm64: entry: Add non-kpti __bp_harden_el1_vectors for mitigations James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 19/27] arm64: entry: Add vectors that have the bhb mitigation sequences James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 20/27] arm64: entry: Add macro for reading symbol addresses from the trampoline James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 21/27] arm64: Add percpu vectors for EL1 James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 22/27] arm64: proton-pack: Report Spectre-BHB vulnerabilities as part of Spectre-v2 James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 23/27] KVM: arm64: Add templates for BHB mitigation sequences James Morse
2022-03-31 18:33 ` [stable:PATCH v4.14.274 24/27] arm64: Mitigate spectre style branch history side channels James Morse
2022-03-31 18:33 ` James Morse [this message]
2022-03-31 18:33 ` [stable:PATCH v4.14.274 26/27] arm64: add ID_AA64ISAR2_EL1 sys register James Morse
2022-03-31 18:34 ` [stable:PATCH v4.14.274 27/27] arm64: Use the clearbhb instruction in mitigations James Morse
2022-03-31 19:03 ` [stable:PATCH v4.14.274 00/27] arm64: Mitigate spectre style branch history side channels Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220331183400.73183-26-james.morse@arm.com \
    --to=james.morse@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox