* [PATCH] drm/nouveau: change base917c_format from global to static
@ 2022-04-18 14:18 Tom Rix
2022-04-18 18:41 ` Lyude Paul
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2022-04-18 14:18 UTC (permalink / raw)
To: bskeggs, kherbst, lyude, airlied, daniel
Cc: dri-devel, nouveau, linux-kernel, Tom Rix
Smatch reports this issue
base917c.c:26:1: warning: symbol 'base917c_format'
was not declared. Should it be static?
base917c_format is only used in base917.c. Single
file variables should not be global so change
base917c_format's storage-class specifier to static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/nouveau/dispnv50/base917c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/base917c.c b/drivers/gpu/drm/nouveau/dispnv50/base917c.c
index a1baed4fe0e9..ca260509a4f1 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/base917c.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/base917c.c
@@ -22,7 +22,7 @@
#include "base.h"
#include "atom.h"
-const u32
+static const u32
base917c_format[] = {
DRM_FORMAT_C8,
DRM_FORMAT_XRGB8888,
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/nouveau: change base917c_format from global to static
2022-04-18 14:18 [PATCH] drm/nouveau: change base917c_format from global to static Tom Rix
@ 2022-04-18 18:41 ` Lyude Paul
0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2022-04-18 18:41 UTC (permalink / raw)
To: Tom Rix, bskeggs, kherbst, airlied, daniel
Cc: dri-devel, nouveau, linux-kernel
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push this to the appropriate branch in a little bit
On Mon, 2022-04-18 at 10:18 -0400, Tom Rix wrote:
> Smatch reports this issue
> base917c.c:26:1: warning: symbol 'base917c_format'
> was not declared. Should it be static?
>
> base917c_format is only used in base917.c. Single
> file variables should not be global so change
> base917c_format's storage-class specifier to static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/nouveau/dispnv50/base917c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/base917c.c
> b/drivers/gpu/drm/nouveau/dispnv50/base917c.c
> index a1baed4fe0e9..ca260509a4f1 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/base917c.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/base917c.c
> @@ -22,7 +22,7 @@
> #include "base.h"
> #include "atom.h"
>
> -const u32
> +static const u32
> base917c_format[] = {
> DRM_FORMAT_C8,
> DRM_FORMAT_XRGB8888,
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-18 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-18 14:18 [PATCH] drm/nouveau: change base917c_format from global to static Tom Rix
2022-04-18 18:41 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox