* [PATCH] libnvdimm/security: change __nvdimm_security_overwrite_query from global to static
@ 2022-04-21 15:39 Tom Rix
0 siblings, 0 replies; only message in thread
From: Tom Rix @ 2022-04-21 15:39 UTC (permalink / raw)
To: dan.j.williams, vishal.l.verma, dave.jiang, ira.weiny
Cc: nvdimm, linux-kernel, Tom Rix
Smatch reports this issue
security.c:416:6: warning: symbol '__nvdimm_security_overwrite_query' was not declared. Should it be static?
__nvdimm_security_overwrite_query is only used in security.c so change
its storage-class specifier to static
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/nvdimm/security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/security.c b/drivers/nvdimm/security.c
index 4b80150e4afa..d3e782662bf4 100644
--- a/drivers/nvdimm/security.c
+++ b/drivers/nvdimm/security.c
@@ -413,7 +413,7 @@ static int security_overwrite(struct nvdimm *nvdimm, unsigned int keyid)
return rc;
}
-void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm)
+static void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm)
{
struct nvdimm_bus *nvdimm_bus = walk_to_nvdimm_bus(&nvdimm->dev);
int rc;
--
2.27.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-21 15:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-21 15:39 [PATCH] libnvdimm/security: change __nvdimm_security_overwrite_query from global to static Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox