From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Guo Zhengkui <guozhengkui@vivo.com>
Cc: Conor Culhane <conor.culhane@silvaco.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
zhengkui_guo@outlook.com
Subject: Re: [PATCH] i3c: master: svc: fix returnvar.cocci warning
Date: Mon, 9 May 2022 15:22:05 +0200 [thread overview]
Message-ID: <20220509152205.5e6432e1@xps13> (raw)
In-Reply-To: <20220504164901.9622-1-guozhengkui@vivo.com>
Hi,
guozhengkui@vivo.com wrote on Thu, 5 May 2022 00:49:01 +0800:
> Fix the following coccicheck warning:
>
> drivers/i3c/master/svc-i3c-master.c:1600:5-8:
> Unneeded variable: "ret". Return "0" on line 1605.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 7550dad64ecf..d6e9ed74cdcf 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1597,12 +1597,11 @@ static int __maybe_unused svc_i3c_runtime_suspend(struct device *dev)
> static int __maybe_unused svc_i3c_runtime_resume(struct device *dev)
> {
> struct svc_i3c_master *master = dev_get_drvdata(dev);
> - int ret = 0;
>
> pinctrl_pm_select_default_state(dev);
> svc_i3c_master_prepare_clks(master);
>
> - return ret;
> + return 0;
> }
>
> static const struct dev_pm_ops svc_i3c_pm_ops = {
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2022-05-09 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 16:49 [PATCH] i3c: master: svc: fix returnvar.cocci warning Guo Zhengkui
2022-05-09 13:22 ` Miquel Raynal [this message]
2022-05-17 20:36 ` alexandre.belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509152205.5e6432e1@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=guozhengkui@vivo.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengkui_guo@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox