* [PATCH] i3c: master: svc: fix returnvar.cocci warning
@ 2022-05-04 16:49 Guo Zhengkui
2022-05-09 13:22 ` Miquel Raynal
2022-05-17 20:36 ` alexandre.belloni
0 siblings, 2 replies; 3+ messages in thread
From: Guo Zhengkui @ 2022-05-04 16:49 UTC (permalink / raw)
To: Miquel Raynal, Conor Culhane, Alexandre Belloni, linux-i3c,
linux-kernel
Cc: zhengkui_guo, Guo Zhengkui
Fix the following coccicheck warning:
drivers/i3c/master/svc-i3c-master.c:1600:5-8:
Unneeded variable: "ret". Return "0" on line 1605.
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
drivers/i3c/master/svc-i3c-master.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 7550dad64ecf..d6e9ed74cdcf 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1597,12 +1597,11 @@ static int __maybe_unused svc_i3c_runtime_suspend(struct device *dev)
static int __maybe_unused svc_i3c_runtime_resume(struct device *dev)
{
struct svc_i3c_master *master = dev_get_drvdata(dev);
- int ret = 0;
pinctrl_pm_select_default_state(dev);
svc_i3c_master_prepare_clks(master);
- return ret;
+ return 0;
}
static const struct dev_pm_ops svc_i3c_pm_ops = {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i3c: master: svc: fix returnvar.cocci warning
2022-05-04 16:49 [PATCH] i3c: master: svc: fix returnvar.cocci warning Guo Zhengkui
@ 2022-05-09 13:22 ` Miquel Raynal
2022-05-17 20:36 ` alexandre.belloni
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2022-05-09 13:22 UTC (permalink / raw)
To: Guo Zhengkui
Cc: Conor Culhane, Alexandre Belloni, linux-i3c, linux-kernel,
zhengkui_guo
Hi,
guozhengkui@vivo.com wrote on Thu, 5 May 2022 00:49:01 +0800:
> Fix the following coccicheck warning:
>
> drivers/i3c/master/svc-i3c-master.c:1600:5-8:
> Unneeded variable: "ret". Return "0" on line 1605.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 7550dad64ecf..d6e9ed74cdcf 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1597,12 +1597,11 @@ static int __maybe_unused svc_i3c_runtime_suspend(struct device *dev)
> static int __maybe_unused svc_i3c_runtime_resume(struct device *dev)
> {
> struct svc_i3c_master *master = dev_get_drvdata(dev);
> - int ret = 0;
>
> pinctrl_pm_select_default_state(dev);
> svc_i3c_master_prepare_clks(master);
>
> - return ret;
> + return 0;
> }
>
> static const struct dev_pm_ops svc_i3c_pm_ops = {
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i3c: master: svc: fix returnvar.cocci warning
2022-05-04 16:49 [PATCH] i3c: master: svc: fix returnvar.cocci warning Guo Zhengkui
2022-05-09 13:22 ` Miquel Raynal
@ 2022-05-17 20:36 ` alexandre.belloni
1 sibling, 0 replies; 3+ messages in thread
From: alexandre.belloni @ 2022-05-17 20:36 UTC (permalink / raw)
To: linux-i3c, Miquel Raynal, linux-kernel, Guo Zhengkui,
Conor Culhane
Cc: Alexandre Belloni, zhengkui_guo
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
On Thu, 5 May 2022 00:49:01 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
>
> drivers/i3c/master/svc-i3c-master.c:1600:5-8:
> Unneeded variable: "ret". Return "0" on line 1605.
>
>
Applied, thanks!
[1/1] i3c: master: svc: fix returnvar.cocci warning
commit: 227fab1ee7ca70c9b4b0915898e81327aeb70414
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-17 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-04 16:49 [PATCH] i3c: master: svc: fix returnvar.cocci warning Guo Zhengkui
2022-05-09 13:22 ` Miquel Raynal
2022-05-17 20:36 ` alexandre.belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox