The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny@suse.com>
To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Bui Quang Minh <minhquangbui99@gmail.com>,
	Tadeusz Struk <tadeusz.struk@linaro.org>
Subject: [PATCH 0/2] cgroup_subsys_state lifecycle fixups
Date: Wed, 25 May 2022 17:15:15 +0200	[thread overview]
Message-ID: <20220525151517.8430-1-mkoutny@suse.com> (raw)

Two corner cases were hanging around [2][3] related to css lifecycles,
since they're loosely related I'm sending them together.

The 2nd patch fixes problems encountered in syzbot tests only.
Alternative solutions could be:
- daisy-chain css_release_work_fn from the offending css_killed_work_fn call,
- rework kill_css() not to rely on multi-stage css_killed_work_fn() [1].

The simplest approach was chosen.

The other existing users of percpu_ref_kill_and_confirm are not affected by
similar issues.

[1] Rough idea is to only synchronize via a completion like e.g.
nvmet_sq_destroy() does and move most of css_killed_work_fn() at the end of
kill_css(). kill_css() is only used in process context when de-configuring
controllers or rmdiring a cgroup.

[2] https://lore.kernel.org/lkml/20220404142535.145975-1-minhquangbui99@gmail.com/
[3] https://lore.kernel.org/lkml/20220412192459.227740-1-tadeusz.struk@linaro.org/

Michal Koutný (2):
  cgroup: Wait for cgroup_subsys_state offlining on unmount
  cgroup: Use separate work structs on css release path

 include/linux/cgroup-defs.h |  5 +++--
 kernel/cgroup/cgroup.c      | 19 +++++++++++--------
 2 files changed, 14 insertions(+), 10 deletions(-)

-- 
2.35.3


             reply	other threads:[~2022-05-25 15:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 15:15 Michal Koutný [this message]
2022-05-25 15:15 ` [PATCH 1/2] cgroup: Wait for cgroup_subsys_state offlining on unmount Michal Koutný
2022-05-25 15:15 ` [PATCH 2/2] cgroup: Use separate work structs on css release path Michal Koutný
2022-05-25 16:14   ` Michal Koutný
2022-05-26  9:56     ` Michal Koutný
2022-05-26 18:15       ` Tejun Heo
2022-05-27 16:39         ` Tadeusz Struk
2022-05-27 16:54           ` Michal Koutný
2022-05-27 17:23             ` Tejun Heo
2022-06-01 23:13         ` Tadeusz Struk
2022-06-01 23:20           ` Tejun Heo
2022-06-01 23:37             ` Tadeusz Struk
2022-06-01 23:43               ` Tejun Heo
2022-06-02  0:00                 ` Tadeusz Struk
2022-06-02  0:07                   ` Tejun Heo
2022-06-02  0:26                     ` Tadeusz Struk
2022-06-02  0:29                       ` Tejun Heo
2022-06-02  0:40                         ` Tadeusz Struk
2022-06-02 11:47                           ` Michal Koutný
2022-06-02 14:28                             ` Tadeusz Struk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525151517.8430-1-mkoutny@suse.com \
    --to=mkoutny@suse.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=minhquangbui99@gmail.com \
    --cc=tadeusz.struk@linaro.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox