* [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus'
@ 2022-05-25 20:56 Rob Herring
2022-05-25 22:34 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-05-25 20:56 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, H. Nikolaus Schaller
Cc: dri-devel, devicetree, linux-kernel
While 'ddc-i2c-bus' is a common property, it should be in a connector
node rather than the HDMI bridge node as the I2C bus goes to a
connector and not the HDMI block. Drop it from the example.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
index b8219eab4475..89490fdffeb0 100644
--- a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
@@ -55,7 +55,6 @@ examples:
compatible = "ingenic,jz4780-dw-hdmi";
reg = <0x10180000 0x8000>;
reg-io-width = <4>;
- ddc-i2c-bus = <&i2c4>;
interrupt-parent = <&intc>;
interrupts = <3>;
clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus'
2022-05-25 20:56 [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus' Rob Herring
@ 2022-05-25 22:34 ` Laurent Pinchart
2022-05-26 11:54 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2022-05-25 22:34 UTC (permalink / raw)
To: Rob Herring
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
H. Nikolaus Schaller, dri-devel, devicetree, linux-kernel
Hi Rob,
Thank you for the patch.
On Wed, May 25, 2022 at 03:56:26PM -0500, Rob Herring wrote:
> While 'ddc-i2c-bus' is a common property, it should be in a connector
> node rather than the HDMI bridge node as the I2C bus goes to a
> connector and not the HDMI block. Drop it from the example.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> index b8219eab4475..89490fdffeb0 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> @@ -55,7 +55,6 @@ examples:
> compatible = "ingenic,jz4780-dw-hdmi";
> reg = <0x10180000 0x8000>;
> reg-io-width = <4>;
> - ddc-i2c-bus = <&i2c4>;
> interrupt-parent = <&intc>;
> interrupts = <3>;
> clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus'
2022-05-25 22:34 ` Laurent Pinchart
@ 2022-05-26 11:54 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-05-26 11:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Rob Herring, Andrzej Hajda, Neil Armstrong, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
H. Nikolaus Schaller, dri-devel, devicetree, linux-kernel
On Thu, 26 May 2022 at 00:34, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Wed, May 25, 2022 at 03:56:26PM -0500, Rob Herring wrote:
> > While 'ddc-i2c-bus' is a common property, it should be in a connector
> > node rather than the HDMI bridge node as the I2C bus goes to a
> > connector and not the HDMI block. Drop it from the example.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> > .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > index b8219eab4475..89490fdffeb0 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > @@ -55,7 +55,6 @@ examples:
> > compatible = "ingenic,jz4780-dw-hdmi";
> > reg = <0x10180000 0x8000>;
> > reg-io-width = <4>;
> > - ddc-i2c-bus = <&i2c4>;
> > interrupt-parent = <&intc>;
> > interrupts = <3>;
> > clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
>
> --
> Regards,
>
> Laurent Pinchart
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-26 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-25 20:56 [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus' Rob Herring
2022-05-25 22:34 ` Laurent Pinchart
2022-05-26 11:54 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox