* [PATCH] efi: sysfb_efi: remove unnecessary <asm/efi.h> include
@ 2022-06-10 9:00 Javier Martinez Canillas
2022-06-10 9:09 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2022-06-10 9:00 UTC (permalink / raw)
To: linux-kernel
Cc: Stephen Rothwell, Javier Martinez Canillas, Ard Biesheuvel,
linux-efi
Nothing defined in the header is used by drivers/firmware/efi/sysfb_efi.c
but also, including it can lead to build errors when built on arches that
don't have an asm/efi.h header file.
This can happen for example if a driver that is built when COMPILE_TEST is
enabled selects the SYSFB symbol, e.g. on powerpc with allyesconfig:
drivers/firmware/efi/sysfb_efi.c:29:10: fatal error: asm/efi.h: No such file or directory
29 | #include <asm/efi.h>
| ^~~~~~~~~~~
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/firmware/efi/sysfb_efi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
index 4c7c9dd7733f..7882d4b3f2be 100644
--- a/drivers/firmware/efi/sysfb_efi.c
+++ b/drivers/firmware/efi/sysfb_efi.c
@@ -26,8 +26,6 @@
#include <linux/sysfb.h>
#include <video/vga.h>
-#include <asm/efi.h>
-
enum {
OVERRIDE_NONE = 0x0,
OVERRIDE_BASE = 0x1,
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] efi: sysfb_efi: remove unnecessary <asm/efi.h> include
2022-06-10 9:00 [PATCH] efi: sysfb_efi: remove unnecessary <asm/efi.h> include Javier Martinez Canillas
@ 2022-06-10 9:09 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2022-06-10 9:09 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Linux Kernel Mailing List, Stephen Rothwell, linux-efi
On Fri, 10 Jun 2022 at 11:00, Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Nothing defined in the header is used by drivers/firmware/efi/sysfb_efi.c
> but also, including it can lead to build errors when built on arches that
> don't have an asm/efi.h header file.
>
> This can happen for example if a driver that is built when COMPILE_TEST is
> enabled selects the SYSFB symbol, e.g. on powerpc with allyesconfig:
>
> drivers/firmware/efi/sysfb_efi.c:29:10: fatal error: asm/efi.h: No such file or directory
> 29 | #include <asm/efi.h>
> | ^~~~~~~~~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Queued up in efi/urgent, thanks
> ---
>
> drivers/firmware/efi/sysfb_efi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
> index 4c7c9dd7733f..7882d4b3f2be 100644
> --- a/drivers/firmware/efi/sysfb_efi.c
> +++ b/drivers/firmware/efi/sysfb_efi.c
> @@ -26,8 +26,6 @@
> #include <linux/sysfb.h>
> #include <video/vga.h>
>
> -#include <asm/efi.h>
> -
> enum {
> OVERRIDE_NONE = 0x0,
> OVERRIDE_BASE = 0x1,
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-10 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-10 9:00 [PATCH] efi: sysfb_efi: remove unnecessary <asm/efi.h> include Javier Martinez Canillas
2022-06-10 9:09 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox