* [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl
@ 2022-06-17 12:25 Liang He
2022-06-21 15:15 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-17 12:25 UTC (permalink / raw)
To: john, tsbogend, xkernel.wang; +Cc: windhl, linux-mips, linux-kernel
In ltq_soc_init(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put() when
it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/mips/lantiq/xway/sysctrl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
index 084f6caba5f2..d444a1b98a72 100644
--- a/arch/mips/lantiq/xway/sysctrl.c
+++ b/arch/mips/lantiq/xway/sysctrl.c
@@ -441,6 +441,10 @@ void __init ltq_soc_init(void)
of_address_to_resource(np_ebu, 0, &res_ebu))
panic("Failed to get core resources");
+ of_node_put(np_pmu);
+ of_node_put(np_cgu);
+ of_node_put(np_ebu);
+
if (!request_mem_region(res_pmu.start, resource_size(&res_pmu),
res_pmu.name) ||
!request_mem_region(res_cgu.start, resource_size(&res_cgu),
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl
2022-06-17 12:25 [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl Liang He
@ 2022-06-21 15:15 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2022-06-21 15:15 UTC (permalink / raw)
To: Liang He; +Cc: john, xkernel.wang, linux-mips, linux-kernel
On Fri, Jun 17, 2022 at 08:25:05PM +0800, Liang He wrote:
> In ltq_soc_init(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> arch/mips/lantiq/xway/sysctrl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
> index 084f6caba5f2..d444a1b98a72 100644
> --- a/arch/mips/lantiq/xway/sysctrl.c
> +++ b/arch/mips/lantiq/xway/sysctrl.c
> @@ -441,6 +441,10 @@ void __init ltq_soc_init(void)
> of_address_to_resource(np_ebu, 0, &res_ebu))
> panic("Failed to get core resources");
>
> + of_node_put(np_pmu);
> + of_node_put(np_cgu);
> + of_node_put(np_ebu);
> +
> if (!request_mem_region(res_pmu.start, resource_size(&res_pmu),
> res_pmu.name) ||
> !request_mem_region(res_cgu.start, resource_size(&res_cgu),
> --
> 2.25.1
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-21 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-17 12:25 [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl Liang He
2022-06-21 15:15 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox