From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chang Yu <marcus.yu.56@gmail.com>
Cc: Greg KH <greg@kroah.com>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: combine nested if statements into one
Date: Fri, 24 Jun 2022 08:39:30 +0300 [thread overview]
Message-ID: <20220624053930.GU16517@kadam> (raw)
In-Reply-To: <YrUw3lejTP0UyWmt@zephyrus-g14.localdomain>
On Thu, Jun 23, 2022 at 08:34:54PM -0700, Chang Yu wrote:
> > - You did not specify a description of why the patch is needed,
>
> I'm not entirely sure how to fix this. I checked the original patch
> again and the subject and the body looks OK to me. I'm still a newbie so
> I might have missed a couple of things. It would be greatly appreciated
> if someone could point out what's missing.
What's the advantage of combining if statements? Out of all the if
statements in the kernel why did you pick that one? Probably it's
because the indenting was wrong, no?
Write the commit message like this:
[PATCH v3] staging: r8188eu: clean up if statement
I noticed that the if statement was strange and the code was indented
too far. It is cleaner to combine both if statements as well.
regards,
dan carpenter
next prev parent reply other threads:[~2022-06-24 5:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 3:15 [PATCH] staging: r8188eu: combine nested if statements into one Chang Yu
2022-06-23 4:58 ` Philipp Hortmann
2022-06-23 12:05 ` David Laight
2022-06-24 3:30 ` Chang Yu
2022-06-24 5:26 ` Philipp Hortmann
2022-06-23 5:14 ` [PATCH v2] " Chang Yu
2022-06-23 5:53 ` Philipp Hortmann
2022-06-23 9:45 ` Greg KH
2022-06-24 3:34 ` Chang Yu
2022-06-24 5:39 ` Dan Carpenter [this message]
2022-06-24 5:52 ` Chang Yu
2022-06-24 5:47 ` Philipp Hortmann
2022-06-24 5:59 ` Chang Yu
2022-06-24 6:27 ` [PATCH v3] staging: r8188eu: core/rtw_recv.c: clean up nested if statements Chang Yu
2022-06-24 6:42 ` Greg KH
2022-06-24 14:45 ` [PATCH v4] " Chang Yu
2022-06-24 18:01 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624053930.GU16517@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcus.yu.56@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox