public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chang Yu <marcus.yu.56@gmail.com>
To: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Chang Yu <marcus.yu.56@gmail.com>
Subject: [PATCH v4] staging: r8188eu: core/rtw_recv.c: clean up nested if statements
Date: Fri, 24 Jun 2022 07:45:26 -0700	[thread overview]
Message-ID: <20220624144526.437322-1-marcus.yu.56@gmail.com> (raw)
In-Reply-To: <20220623031515.402691-1-marcus.yu.56@gmail.com>

Combine two nested if statements into a single one to fix indentation
issue and improve readability, as suggested by checkpatch.pl

Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
---
Changes in v4:
 - Added missing change log and resend

Changes in v3:
 - Modified subject and description to be more descriptive

Changes in v2:
 - Added a pair of parentheses to make operator precedence explicit


 drivers/staging/r8188eu/core/rtw_recv.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index 6564e82ddd66..020bc212532f 100644
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -166,10 +166,8 @@ int rtw_free_recvframe(struct recv_frame *precvframe, struct __queue *pfree_recv
 
 	list_add_tail(&precvframe->list, get_list_head(pfree_recv_queue));
 
-	if (padapter) {
-		if (pfree_recv_queue == &precvpriv->free_recv_queue)
-				precvpriv->free_recvframe_cnt++;
-	}
+	if (padapter && (pfree_recv_queue == &precvpriv->free_recv_queue))
+		precvpriv->free_recvframe_cnt++;
 
 	spin_unlock_bh(&pfree_recv_queue->lock);
 
-- 
2.36.1


  parent reply	other threads:[~2022-06-24 14:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23  3:15 [PATCH] staging: r8188eu: combine nested if statements into one Chang Yu
2022-06-23  4:58 ` Philipp Hortmann
2022-06-23 12:05   ` David Laight
2022-06-24  3:30     ` Chang Yu
2022-06-24  5:26       ` Philipp Hortmann
2022-06-23  5:14 ` [PATCH v2] " Chang Yu
2022-06-23  5:53   ` Philipp Hortmann
2022-06-23  9:45   ` Greg KH
2022-06-24  3:34     ` Chang Yu
2022-06-24  5:39       ` Dan Carpenter
2022-06-24  5:52         ` Chang Yu
2022-06-24  5:47       ` Philipp Hortmann
2022-06-24  5:59         ` Chang Yu
2022-06-24  6:27 ` [PATCH v3] staging: r8188eu: core/rtw_recv.c: clean up nested if statements Chang Yu
2022-06-24  6:42   ` Greg KH
2022-06-24 14:45 ` Chang Yu [this message]
2022-06-24 18:01   ` [PATCH v4] " Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624144526.437322-1-marcus.yu.56@gmail.com \
    --to=marcus.yu.56@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox