* Re: [Linaro-mm-sig] [PATCH] drm/i915: Remove __dma_fence_is_chain()
2022-06-28 23:35 [PATCH] drm/i915: Remove __dma_fence_is_chain() Rob Clark
@ 2022-06-29 5:34 ` Thomas Hellström (Intel)
2022-06-29 6:57 ` Christian König
2022-06-30 14:29 ` [Intel-gfx] " Andrzej Hajda
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Hellström (Intel) @ 2022-06-29 5:34 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: intel-gfx, Rob Clark, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, David Airlie, Daniel Vetter, Sumit Semwal,
Christian König, Matthew Auld, Maarten Lankhorst,
Thomas Hellström, open list,
open list:DMA BUFFER SHARING FRAMEWORK,
moderated list:DMA BUFFER SHARING FRAMEWORK
On 6/29/22 01:35, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> drive-by cleanup
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 319936f91ac5..667841780514 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
> rcu_read_unlock();
> }
>
> -static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
> -{
> - return fence->ops == &dma_fence_chain_ops;
> -}
> -
> void i915_gem_fence_wait_priority(struct dma_fence *fence,
> const struct i915_sched_attr *attr)
> {
> @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
>
> for (i = 0; i < array->num_fences; i++)
> fence_set_priority(array->fences[i], attr);
> - } else if (__dma_fence_is_chain(fence)) {
> + } else if (dma_fence_is_chain(fence)) {
> struct dma_fence *iter;
>
> /* The chain is ordered; if we boost the last, we boost all */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Remove __dma_fence_is_chain()
2022-06-28 23:35 [PATCH] drm/i915: Remove __dma_fence_is_chain() Rob Clark
2022-06-29 5:34 ` [Linaro-mm-sig] " Thomas Hellström (Intel)
@ 2022-06-29 6:57 ` Christian König
2022-06-30 14:29 ` [Intel-gfx] " Andrzej Hajda
2 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2022-06-29 6:57 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: intel-gfx, Rob Clark, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, David Airlie, Daniel Vetter, Sumit Semwal,
Matthew Auld, Maarten Lankhorst, Thomas Hellström, open list,
open list:DMA BUFFER SHARING FRAMEWORK,
moderated list:DMA BUFFER SHARING FRAMEWORK
Am 29.06.22 um 01:35 schrieb Rob Clark:
> From: Rob Clark <robdclark@chromium.org>
>
> drive-by cleanup
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
We should probably completely remove that dependency and rather use
dma_fence_unwrap instead.
But that's probably for another patch Reviewed-by: Christian König
<christian.koenig@amd.com>.
Christian.
> ---
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 319936f91ac5..667841780514 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
> rcu_read_unlock();
> }
>
> -static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
> -{
> - return fence->ops == &dma_fence_chain_ops;
> -}
> -
> void i915_gem_fence_wait_priority(struct dma_fence *fence,
> const struct i915_sched_attr *attr)
> {
> @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
>
> for (i = 0; i < array->num_fences; i++)
> fence_set_priority(array->fences[i], attr);
> - } else if (__dma_fence_is_chain(fence)) {
> + } else if (dma_fence_is_chain(fence)) {
> struct dma_fence *iter;
>
> /* The chain is ordered; if we boost the last, we boost all */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain()
2022-06-28 23:35 [PATCH] drm/i915: Remove __dma_fence_is_chain() Rob Clark
2022-06-29 5:34 ` [Linaro-mm-sig] " Thomas Hellström (Intel)
2022-06-29 6:57 ` Christian König
@ 2022-06-30 14:29 ` Andrzej Hajda
2 siblings, 0 replies; 4+ messages in thread
From: Andrzej Hajda @ 2022-06-30 14:29 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: Rob Clark, Thomas Hellström, David Airlie, intel-gfx,
open list, Christian König,
moderated list:DMA BUFFER SHARING FRAMEWORK, Matthew Auld,
Rodrigo Vivi, Sumit Semwal,
open list:DMA BUFFER SHARING FRAMEWORK
On 29.06.2022 01:35, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> drive-by cleanup
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 319936f91ac5..667841780514 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
> rcu_read_unlock();
> }
>
> -static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
> -{
> - return fence->ops == &dma_fence_chain_ops;
> -}
> -
> void i915_gem_fence_wait_priority(struct dma_fence *fence,
> const struct i915_sched_attr *attr)
> {
> @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
>
> for (i = 0; i < array->num_fences; i++)
> fence_set_priority(array->fences[i], attr);
> - } else if (__dma_fence_is_chain(fence)) {
> + } else if (dma_fence_is_chain(fence)) {
> struct dma_fence *iter;
>
> /* The chain is ordered; if we boost the last, we boost all */
^ permalink raw reply [flat|nested] 4+ messages in thread