* [PATCH] lib/scatterlist: use matched parameter type when call __sg_free_table
@ 2022-06-29 3:02 wuchi
2022-06-29 12:43 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: wuchi @ 2022-06-29 3:02 UTC (permalink / raw)
To: maorg, ming.lei, hch, akpm; +Cc: linux-kernel
commit <4635873c561a> (scsi: lib/sg_pool.c: improve APIs for
allocating sg pool) had change @(bool)skip_first_chunk of
__sg_free_table to @(unsigned int)nents_first_chunk, so use unsigend
int type instead of bool type (false -> 0) when call the function in
sg_free_append_table and sg_free_table.
Signed-off-by: wuchi <wuchi.zero@gmail.com>
---
lib/scatterlist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index d5e82e4a57ad..c8c3d675845c 100644
--- a/lib/scatterlist.c
+++ b/lib/scatterlist.c
@@ -240,7 +240,7 @@ EXPORT_SYMBOL(__sg_free_table);
**/
void sg_free_append_table(struct sg_append_table *table)
{
- __sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
+ __sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
table->total_nents);
}
EXPORT_SYMBOL(sg_free_append_table);
@@ -253,7 +253,7 @@ EXPORT_SYMBOL(sg_free_append_table);
**/
void sg_free_table(struct sg_table *table)
{
- __sg_free_table(table, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
+ __sg_free_table(table, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
table->orig_nents);
}
EXPORT_SYMBOL(sg_free_table);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] lib/scatterlist: use matched parameter type when call __sg_free_table
2022-06-29 3:02 [PATCH] lib/scatterlist: use matched parameter type when call __sg_free_table wuchi
@ 2022-06-29 12:43 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2022-06-29 12:43 UTC (permalink / raw)
To: wuchi; +Cc: maorg, hch, akpm, linux-kernel
On Wed, Jun 29, 2022 at 11:02:41AM +0800, wuchi wrote:
> commit <4635873c561a> (scsi: lib/sg_pool.c: improve APIs for
> allocating sg pool) had change @(bool)skip_first_chunk of
> __sg_free_table to @(unsigned int)nents_first_chunk, so use unsigend
> int type instead of bool type (false -> 0) when call the function in
> sg_free_append_table and sg_free_table.
>
> Signed-off-by: wuchi <wuchi.zero@gmail.com>
> ---
> lib/scatterlist.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/scatterlist.c b/lib/scatterlist.c
> index d5e82e4a57ad..c8c3d675845c 100644
> --- a/lib/scatterlist.c
> +++ b/lib/scatterlist.c
> @@ -240,7 +240,7 @@ EXPORT_SYMBOL(__sg_free_table);
> **/
> void sg_free_append_table(struct sg_append_table *table)
> {
> - __sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
> + __sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
> table->total_nents);
> }
> EXPORT_SYMBOL(sg_free_append_table);
> @@ -253,7 +253,7 @@ EXPORT_SYMBOL(sg_free_append_table);
> **/
> void sg_free_table(struct sg_table *table)
> {
> - __sg_free_table(table, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
> + __sg_free_table(table, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
> table->orig_nents);
> }
> EXPORT_SYMBOL(sg_free_table);
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-29 3:02 [PATCH] lib/scatterlist: use matched parameter type when call __sg_free_table wuchi
2022-06-29 12:43 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox