* [PATCH] watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe()
@ 2022-07-22 3:09 williamsukatube
2022-07-22 3:42 ` Guenter Roeck
2022-07-22 7:14 ` Marek Behún
0 siblings, 2 replies; 3+ messages in thread
From: williamsukatube @ 2022-07-22 3:09 UTC (permalink / raw)
To: kabel, wim, linux, linux-watchdog, linux-kernel
Cc: William Dean, Hacash Robot
From: William Dean <williamsukatube@gmail.com>
The function devm_ioremap() in armada_37xx_wdt_probe() can fail, so
its return value should be checked.
Fixes: 54e3d9b518c8a ("watchdog: Add support for Armada 37xx CPU watchdog")
Reported-by: Hacash Robot <hacashRobot@santino.com>
Signed-off-by: William Dean <williamsukatube@gmail.com>
---
drivers/watchdog/armada_37xx_wdt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada_37xx_wdt.c
index 1635f421ef2c..854b1cc723cb 100644
--- a/drivers/watchdog/armada_37xx_wdt.c
+++ b/drivers/watchdog/armada_37xx_wdt.c
@@ -274,6 +274,8 @@ static int armada_37xx_wdt_probe(struct platform_device *pdev)
if (!res)
return -ENODEV;
dev->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+ if (!dev->reg)
+ return -ENOMEM;
/* init clock */
dev->clk = devm_clk_get(&pdev->dev, NULL);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe()
2022-07-22 3:09 [PATCH] watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe() williamsukatube
@ 2022-07-22 3:42 ` Guenter Roeck
2022-07-22 7:14 ` Marek Behún
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-07-22 3:42 UTC (permalink / raw)
To: williamsukatube, kabel, wim, linux-watchdog, linux-kernel
Cc: William Dean, Hacash Robot
On 7/21/22 20:09, williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@gmail.com>
>
> The function devm_ioremap() in armada_37xx_wdt_probe() can fail, so
> its return value should be checked.
>
> Fixes: 54e3d9b518c8a ("watchdog: Add support for Armada 37xx CPU watchdog")
> Reported-by: Hacash Robot <hacashRobot@santino.com>
> Signed-off-by: William Dean <williamsukatube@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/armada_37xx_wdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada_37xx_wdt.c
> index 1635f421ef2c..854b1cc723cb 100644
> --- a/drivers/watchdog/armada_37xx_wdt.c
> +++ b/drivers/watchdog/armada_37xx_wdt.c
> @@ -274,6 +274,8 @@ static int armada_37xx_wdt_probe(struct platform_device *pdev)
> if (!res)
> return -ENODEV;
> dev->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res));
> + if (!dev->reg)
> + return -ENOMEM;
>
> /* init clock */
> dev->clk = devm_clk_get(&pdev->dev, NULL);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe()
2022-07-22 3:09 [PATCH] watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe() williamsukatube
2022-07-22 3:42 ` Guenter Roeck
@ 2022-07-22 7:14 ` Marek Behún
1 sibling, 0 replies; 3+ messages in thread
From: Marek Behún @ 2022-07-22 7:14 UTC (permalink / raw)
To: williamsukatube
Cc: wim, linux, linux-watchdog, linux-kernel, William Dean,
Hacash Robot
On Fri, 22 Jul 2022 11:09:38 +0800
williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@gmail.com>
>
> The function devm_ioremap() in armada_37xx_wdt_probe() can fail, so
> its return value should be checked.
>
> Fixes: 54e3d9b518c8a ("watchdog: Add support for Armada 37xx CPU watchdog")
> Reported-by: Hacash Robot <hacashRobot@santino.com>
> Signed-off-by: William Dean <williamsukatube@gmail.com>
> ---
> drivers/watchdog/armada_37xx_wdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/armada_37xx_wdt.c b/drivers/watchdog/armada_37xx_wdt.c
> index 1635f421ef2c..854b1cc723cb 100644
> --- a/drivers/watchdog/armada_37xx_wdt.c
> +++ b/drivers/watchdog/armada_37xx_wdt.c
> @@ -274,6 +274,8 @@ static int armada_37xx_wdt_probe(struct platform_device *pdev)
> if (!res)
> return -ENODEV;
> dev->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res));
> + if (!dev->reg)
> + return -ENOMEM;
>
> /* init clock */
> dev->clk = devm_clk_get(&pdev->dev, NULL);
Reviewed-by: Marek Behún <kabel@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-22 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-22 3:09 [PATCH] watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe() williamsukatube
2022-07-22 3:42 ` Guenter Roeck
2022-07-22 7:14 ` Marek Behún
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox