* [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
@ 2022-08-30 18:33 Andy Shevchenko
2022-09-02 16:38 ` Rob Herring
2022-09-09 9:45 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-08-30 18:33 UTC (permalink / raw)
To: Bjorn Helgaas, Mauro Carvalho Chehab, linux-pci, linux-kernel
Cc: Xiaowei Song, Binghui Wang, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Andy Shevchenko
As a preparation to unexport of_gpio_named_count(), convert the
driver to use gpiod_count() instead.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pci/controller/dwc/pcie-kirin.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
index 7f67aad71df4..3bde045e20ad 100644
--- a/drivers/pci/controller/dwc/pcie-kirin.c
+++ b/drivers/pci/controller/dwc/pcie-kirin.c
@@ -366,12 +366,11 @@ static int kirin_pcie_get_gpio_enable(struct kirin_pcie *pcie,
struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *np = dev->of_node;
char name[32];
int ret, i;
/* This is an optional property */
- ret = of_gpio_named_count(np, "hisilicon,clken-gpios");
+ ret = gpiod_count(dev, "hisilicon,clken");
if (ret < 0)
return 0;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
2022-08-30 18:33 [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count() Andy Shevchenko
@ 2022-09-02 16:38 ` Rob Herring
2022-09-09 9:45 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-09-02 16:38 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bjorn Helgaas, Mauro Carvalho Chehab, PCI,
linux-kernel@vger.kernel.org, Xiaowei Song, Binghui Wang,
Lorenzo Pieralisi, Krzysztof Wilczyński
On Tue, Aug 30, 2022 at 1:33 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> As a preparation to unexport of_gpio_named_count(), convert the
> driver to use gpiod_count() instead.
I'm always in favor of removing DT APIs.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pci/controller/dwc/pcie-kirin.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
2022-08-30 18:33 [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count() Andy Shevchenko
2022-09-02 16:38 ` Rob Herring
@ 2022-09-09 9:45 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2022-09-09 9:45 UTC (permalink / raw)
To: Andy Shevchenko, Bjorn Helgaas, linux-pci, Mauro Carvalho Chehab,
linux-kernel
Cc: Lorenzo Pieralisi, Binghui Wang, Rob Herring, Xiaowei Song,
Krzysztof Wilczyński
On Tue, 30 Aug 2022 21:33:10 +0300, Andy Shevchenko wrote:
> As a preparation to unexport of_gpio_named_count(), convert the
> driver to use gpiod_count() instead.
>
>
Applied to pci/dwc, thanks!
[1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
https://git.kernel.org/lpieralisi/pci/c/2023f9c9190e
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-09 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-30 18:33 [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count() Andy Shevchenko
2022-09-02 16:38 ` Rob Herring
2022-09-09 9:45 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox