* [PATCH][next] mm/memremap: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
@ 2022-09-02 23:17 Gustavo A. R. Silva
2022-09-03 5:10 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2022-09-02 23:17 UTC (permalink / raw)
To: linux-kernel, Gustavo A. R. Silva, linux-hardening
Zero-length arrays are deprecated and we are moving towards adopting
C99 flexible-array members, instead. So, replace zero-length array
declaration in struct dev_pagemap with the new DECLARE_FLEX_ARRAY()
helper macro.
This helper allows for a flexible-array member in a union.
Also, this addresses multiple warnings reported when building
with Clang-15 and -Wzero-length-array.
Link: https://github.com/KSPP/linux/issues/193
Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
include/linux/memremap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/memremap.h b/include/linux/memremap.h
index c3b4cc84877b..ad3c38840194 100644
--- a/include/linux/memremap.h
+++ b/include/linux/memremap.h
@@ -135,7 +135,7 @@ struct dev_pagemap {
int nr_range;
union {
struct range range;
- struct range ranges[0];
+ DECLARE_FLEX_ARRAY(struct range, ranges);
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] mm/memremap: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
2022-09-02 23:17 [PATCH][next] mm/memremap: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Gustavo A. R. Silva
@ 2022-09-03 5:10 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2022-09-03 5:10 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-kernel, linux-hardening
On Sat, Sep 03, 2022 at 12:17:18AM +0100, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated and we are moving towards adopting
> C99 flexible-array members, instead. So, replace zero-length array
> declaration in struct dev_pagemap with the new DECLARE_FLEX_ARRAY()
> helper macro.
>
> This helper allows for a flexible-array member in a union.
>
> Also, this addresses multiple warnings reported when building
> with Clang-15 and -Wzero-length-array.
>
> Link: https://github.com/KSPP/linux/issues/193
> Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-03 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-02 23:17 [PATCH][next] mm/memremap: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Gustavo A. R. Silva
2022-09-03 5:10 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox