From: Marcelo Tosatti <mtosatti@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Frederic Weisbecker <frederic@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Prasad Pandit <ppandit@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Yair Podemsky <ypodemsk@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [RFC PATCH 6/7] perf_event_open: check for block interference CPUs
Date: Thu, 08 Sep 2022 16:29:05 -0300 [thread overview]
Message-ID: <20220908195111.915923599@redhat.com> (raw)
In-Reply-To: 20220908192859.546633738@redhat.com
When creating perf events, return an error rather
than interfering with CPUs tagged as block interference.
Note: this patch is incomplete, installation of perf context
on block interference CPUs via task context is not performed.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: linux-2.6/kernel/events/core.c
===================================================================
--- linux-2.6.orig/kernel/events/core.c
+++ linux-2.6/kernel/events/core.c
@@ -54,6 +54,7 @@
#include <linux/highmem.h>
#include <linux/pgtable.h>
#include <linux/buildid.h>
+#include <linux/sched/isolation.h>
#include "internal.h"
@@ -12391,6 +12392,26 @@ not_move_group:
WARN_ON_ONCE(ctx->parent_ctx);
+ block_interf_read_lock();
+ if (!task) {
+ if (move_group) {
+ for_each_sibling_event(sibling, group_leader) {
+ if (block_interf_cpu(sibling->cpu)) {
+ err = -EPERM;
+ goto err_block_interf;
+ }
+ }
+ if (block_interf_cpu(group_leader->cpu)) {
+ err = -EPERM;
+ goto err_block_interf;
+ }
+ }
+ if (block_interf_cpu(event->cpu)) {
+ err = -EPERM;
+ goto err_block_interf;
+ }
+ }
+
/*
* This is the point on no return; we cannot fail hereafter. This is
* where we start modifying current state.
@@ -12464,6 +12485,8 @@ not_move_group:
put_task_struct(task);
}
+ block_interf_read_unlock();
+
mutex_lock(¤t->perf_event_mutex);
list_add_tail(&event->owner_entry, ¤t->perf_event_list);
mutex_unlock(¤t->perf_event_mutex);
@@ -12478,6 +12501,8 @@ not_move_group:
fd_install(event_fd, event_file);
return event_fd;
+err_block_interf:
+ block_interf_read_unlock();
err_locked:
if (move_group)
perf_event_ctx_unlock(group_leader, gctx);
next prev parent reply other threads:[~2022-09-08 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 19:28 [RFC PATCH 0/7] cpu isolation: infra to block interference to select CPUs Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 1/7] cpu isolation: basic block interference infrastructure Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 2/7] introduce smp_call_func_single_fail Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 3/7] introduce _fail variants of stop_machine functions Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 4/7] clockevent unbind: use smp_call_func_single_fail Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 5/7] timekeeping_notify: use stop_machine_fail when appropriate Marcelo Tosatti
2022-09-08 19:29 ` Marcelo Tosatti [this message]
2022-09-08 19:29 ` [RFC PATCH 7/7] mtrr_add_page/mtrr_del_page: check for block interference CPUs Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908195111.915923599@redhat.com \
--to=mtosatti@redhat.com \
--cc=bristot@kernel.org \
--cc=frederic@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ppandit@redhat.com \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=ypodemsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox