From: Marcelo Tosatti <mtosatti@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Frederic Weisbecker <frederic@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Prasad Pandit <ppandit@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Yair Podemsky <ypodemsk@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [RFC PATCH 7/7] mtrr_add_page/mtrr_del_page: check for block interference CPUs
Date: Thu, 08 Sep 2022 16:29:06 -0300 [thread overview]
Message-ID: <20220908195111.966739489@redhat.com> (raw)
In-Reply-To: 20220908192859.546633738@redhat.com
Check if any online CPU in the system is tagged as
a block interference CPU, and if so return an error
to mtrr_add_page/mtrr_del_page.
This can avoid interference to such CPUs (while allowing
userspace to handle the failures).
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: linux-2.6/arch/x86/kernel/cpu/mtrr/mtrr.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/mtrr.c
+++ linux-2.6/arch/x86/kernel/cpu/mtrr/mtrr.c
@@ -45,6 +45,7 @@
#include <linux/smp.h>
#include <linux/syscore_ops.h>
#include <linux/rcupdate.h>
+#include <linux/sched/isolation.h>
#include <asm/cpufeature.h>
#include <asm/e820/api.h>
@@ -335,6 +336,13 @@ int mtrr_add_page(unsigned long base, un
error = -EINVAL;
replace = -1;
+ block_interf_read_lock();
+
+ if (cpumask_intersects(block_interf_cpumask, cpu_online_mask)) {
+ block_interf_read_unlock();
+ return -EPERM;
+ }
+
/* No CPU hotplug when we change MTRR entries */
cpus_read_lock();
@@ -399,6 +407,7 @@ int mtrr_add_page(unsigned long base, un
out:
mutex_unlock(&mtrr_mutex);
cpus_read_unlock();
+ block_interf_read_unlock();
return error;
}
@@ -484,6 +493,11 @@ int mtrr_del_page(int reg, unsigned long
return -ENODEV;
max = num_var_ranges;
+ block_interf_read_lock();
+ if (cpumask_intersects(block_interf_cpumask, cpu_online_mask)) {
+ block_interf_read_unlock();
+ return -EPERM;
+ }
/* No CPU hotplug when we change MTRR entries */
cpus_read_lock();
mutex_lock(&mtrr_mutex);
@@ -521,6 +535,7 @@ int mtrr_del_page(int reg, unsigned long
out:
mutex_unlock(&mtrr_mutex);
cpus_read_unlock();
+ block_interf_read_unlock();
return error;
}
prev parent reply other threads:[~2022-09-08 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 19:28 [RFC PATCH 0/7] cpu isolation: infra to block interference to select CPUs Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 1/7] cpu isolation: basic block interference infrastructure Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 2/7] introduce smp_call_func_single_fail Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 3/7] introduce _fail variants of stop_machine functions Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 4/7] clockevent unbind: use smp_call_func_single_fail Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 5/7] timekeeping_notify: use stop_machine_fail when appropriate Marcelo Tosatti
2022-09-08 19:29 ` [RFC PATCH 6/7] perf_event_open: check for block interference CPUs Marcelo Tosatti
2022-09-08 19:29 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908195111.966739489@redhat.com \
--to=mtosatti@redhat.com \
--cc=bristot@kernel.org \
--cc=frederic@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ppandit@redhat.com \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=ypodemsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox