* [PATCH v1 1/1] serial: 8250_omap: Convert to use uart_xmit_advance()
@ 2022-09-09 9:12 Andy Shevchenko
2022-09-22 14:10 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-09-09 9:12 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-serial, linux-kernel
Cc: Jiri Slaby, Andy Shevchenko
uart_xmit_advance() provides a common way on how to advance
the Tx queue. Use it for the sake of unification and robustness.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/8250/8250_omap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
index b43894e15b07..4f4d878dc2fc 100644
--- a/drivers/tty/serial/8250/8250_omap.c
+++ b/drivers/tty/serial/8250/8250_omap.c
@@ -984,9 +984,7 @@ static void omap_8250_dma_tx_complete(void *param)
dma->tx_running = 0;
- xmit->tail += dma->tx_size;
- xmit->tail &= UART_XMIT_SIZE - 1;
- p->port.icount.tx += dma->tx_size;
+ uart_xmit_advance(&p->port, dma->tx_size);
if (priv->delayed_restore) {
priv->delayed_restore = 0;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] serial: 8250_omap: Convert to use uart_xmit_advance()
2022-09-09 9:12 [PATCH v1 1/1] serial: 8250_omap: Convert to use uart_xmit_advance() Andy Shevchenko
@ 2022-09-22 14:10 ` Greg Kroah-Hartman
2022-09-22 15:03 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-22 14:10 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-serial, linux-kernel, Jiri Slaby
On Fri, Sep 09, 2022 at 12:12:58PM +0300, Andy Shevchenko wrote:
> uart_xmit_advance() provides a common way on how to advance
> the Tx queue. Use it for the sake of unification and robustness.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_omap.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index b43894e15b07..4f4d878dc2fc 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -984,9 +984,7 @@ static void omap_8250_dma_tx_complete(void *param)
>
> dma->tx_running = 0;
>
> - xmit->tail += dma->tx_size;
> - xmit->tail &= UART_XMIT_SIZE - 1;
> - p->port.icount.tx += dma->tx_size;
> + uart_xmit_advance(&p->port, dma->tx_size);
>
> if (priv->delayed_restore) {
> priv->delayed_restore = 0;
> --
> 2.35.1
>
Breaks the build :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] serial: 8250_omap: Convert to use uart_xmit_advance()
2022-09-22 14:10 ` Greg Kroah-Hartman
@ 2022-09-22 15:03 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-09-22 15:03 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-serial, linux-kernel, Jiri Slaby
On Thu, Sep 22, 2022 at 04:10:40PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 09, 2022 at 12:12:58PM +0300, Andy Shevchenko wrote:
...
> Breaks the build :(
As per other thread, will be sent after v6.1-rc1 is out.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-22 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-09 9:12 [PATCH v1 1/1] serial: 8250_omap: Convert to use uart_xmit_advance() Andy Shevchenko
2022-09-22 14:10 ` Greg Kroah-Hartman
2022-09-22 15:03 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox