From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Kelvin Cheung <keguang.zhang@gmail.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH v2] MIPS: Loongson32: Fix PHY-mode being left unspecified
Date: Mon, 19 Sep 2022 16:47:47 +0200 [thread overview]
Message-ID: <20220919144747.GA7674@alpha.franken.de> (raw)
In-Reply-To: <20220911161009.34453-1-keguang.zhang@gmail.com>
On Mon, Sep 12, 2022 at 12:10:09AM +0800, Kelvin Cheung wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> commit 0060c8783330 ("net: stmmac: implement support for passive mode
> converters via dt") has changed the plat->interface field semantics from
> containing the PHY-mode to specifying the MAC-PCS interface mode. Due to
> that the loongson32 platform code will leave the phylink interface
> uninitialized with the PHY-mode intended by the means of the actual
> platform setup. The commit-author most likely has just missed the
> arch-specific code to fix. Let's mend the Loongson32 platform code then by
> assigning the PHY-mode to the phy_interface field of the STMMAC platform
> data.
>
> Fixes: 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> Tested-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V1 -> V2: Add my SoB tag
> ---
> arch/mips/loongson32/common/platform.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2022-09-19 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 16:10 [PATCH v2] MIPS: Loongson32: Fix PHY-mode being left unspecified Kelvin Cheung
2022-09-19 14:47 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919144747.GA7674@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alexandru.ardelean@analog.com \
--cc=davem@davemloft.net \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox