From: Marcel Ziswiler <marcel@ziswiler.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philippe Schenker <philippe.schenker@toradex.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 1/8] arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci
Date: Thu, 22 Sep 2022 18:29:18 +0200 [thread overview]
Message-ID: <20220922162925.2368577-2-marcel@ziswiler.com> (raw)
In-Reply-To: <20220922162925.2368577-1-marcel@ziswiler.com>
From: Max Krummenacher <max.krummenacher@toradex.com>
The GPIO signaling ctrl_sleep_moci is currently handled as a gpio hog.
But the gpio-hog node is made a child of the wrong gpio controller.
Move it to the node representing gpio4 so that it actually works.
Without this carrier board components jumpered to use the signal are
unconditionally switched off.
Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
.../boot/dts/freescale/imx8mp-verdin.dtsi | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index 1c74c6a19449..360be51a3527 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -339,16 +339,6 @@ &gpio2 {
"SODIMM_82",
"SODIMM_70",
"SODIMM_72";
-
- ctrl-sleep-moci-hog {
- gpio-hog;
- /* Verdin CTRL_SLEEP_MOCI# (SODIMM 256) */
- gpios = <29 GPIO_ACTIVE_HIGH>;
- line-name = "CTRL_SLEEP_MOCI#";
- output-high;
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_ctrl_sleep_moci>;
- };
};
&gpio3 {
@@ -417,6 +407,16 @@ &gpio4 {
"SODIMM_256",
"SODIMM_48",
"SODIMM_44";
+
+ ctrl-sleep-moci-hog {
+ gpio-hog;
+ /* Verdin CTRL_SLEEP_MOCI# (SODIMM 256) */
+ gpios = <29 GPIO_ACTIVE_HIGH>;
+ line-name = "CTRL_SLEEP_MOCI#";
+ output-high;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ctrl_sleep_moci>;
+ };
};
/* On-module I2C */
--
2.36.1
next prev parent reply other threads:[~2022-09-22 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 16:29 [PATCH v1 0/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: pcie. et. al Marcel Ziswiler
2022-09-22 16:29 ` Marcel Ziswiler [this message]
2022-10-23 13:08 ` [PATCH v1 1/8] arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci Shawn Guo
2022-09-22 16:29 ` [PATCH v1 2/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: improve include notation Marcel Ziswiler
2022-10-23 13:09 ` Shawn Guo
2022-10-23 21:27 ` Marcel Ziswiler
2022-09-22 16:29 ` [PATCH v1 3/8] arm64: dts: colibri-imx8x: " Marcel Ziswiler
2022-10-23 13:09 ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 4/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: rename sn65dsi83 to sn65dsi84 Marcel Ziswiler
2022-10-23 13:10 ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 5/8] arm64: dts: verdin-imx8mm: improve pcie node Marcel Ziswiler
2022-10-23 13:11 ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 6/8] arm64: dts: verdin-imx8mp: add pcie support Marcel Ziswiler
2022-10-23 13:12 ` Shawn Guo
2022-10-23 21:46 ` Marcel Ziswiler
2022-09-22 16:29 ` [PATCH v1 7/8] arm64: defconfig: enable snvs lpgpr support Marcel Ziswiler
2022-10-23 13:15 ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 8/8] arm64: defconfig: enable i.mx 8m plus specific interconnect support Marcel Ziswiler
2022-10-23 13:15 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922162925.2368577-2-marcel@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox