The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: "laurent.pinchart@ideasonboard.com" 
	<laurent.pinchart@ideasonboard.com>,
	Max Krummenacher <max.krummenacher@toradex.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	Philippe Schenker <philippe.schenker@toradex.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Andrejs Cainikovs <andrejs.cainikovs@toradex.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v1 2/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: improve include notation
Date: Sun, 23 Oct 2022 21:27:16 +0000	[thread overview]
Message-ID: <69449ded99d51315e0a8133239dcdaa4d1547168.camel@toradex.com> (raw)
In-Reply-To: <20220922162925.2368577-3-marcel@ziswiler.com>

Hi Shawn

On Thu, 2022-09-22 at 18:29 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Improve include notation. Usually only dtsi files from the same location
> are included with an absolute path in quotes. Others should use a
> relative path enclosed in angle brackets.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> 
>  arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 4 ++--
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-
> verdin.dtsi
> index b379c461aa13..a749d063c367 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> @@ -3,8 +3,8 @@
>   * Copyright 2022 Toradex
>   */
>  
> -#include "dt-bindings/phy/phy-imx8-pcie.h"
> -#include "dt-bindings/pwm/pwm.h"
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> +#include <dt-bindings/pwm/pwm.h>
>  #include "imx8mm.dtsi"
>  
>  / {
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-
> verdin.dtsi
> index 360be51a3527..ee4231d138fe 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -3,7 +3,8 @@
>   * Copyright 2022 Toradex
>   */
>  
> -#include "dt-bindings/pwm/pwm.h"
> +#include <dt-bindings/phy/phy-imx8-pcie.h>

Sorry, I just noticed that above line slipped in from patch 6. However, at least it should not hurt as that
header file does indeed exist since quite a while when PCIe support got merged for the Mini.

> +#include <dt-bindings/pwm/pwm.h>
>  #include "imx8mp.dtsi"
>  
>  / {

Cheers

Marcel

  parent reply	other threads:[~2022-10-23 21:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 16:29 [PATCH v1 0/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: pcie. et. al Marcel Ziswiler
2022-09-22 16:29 ` [PATCH v1 1/8] arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci Marcel Ziswiler
2022-10-23 13:08   ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 2/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: improve include notation Marcel Ziswiler
2022-10-23 13:09   ` Shawn Guo
2022-10-23 21:27   ` Marcel Ziswiler [this message]
2022-09-22 16:29 ` [PATCH v1 3/8] arm64: dts: colibri-imx8x: " Marcel Ziswiler
2022-10-23 13:09   ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 4/8] arm64: dts: verdin-imx8mm: verdin-imx8mp: rename sn65dsi83 to sn65dsi84 Marcel Ziswiler
2022-10-23 13:10   ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 5/8] arm64: dts: verdin-imx8mm: improve pcie node Marcel Ziswiler
2022-10-23 13:11   ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 6/8] arm64: dts: verdin-imx8mp: add pcie support Marcel Ziswiler
2022-10-23 13:12   ` Shawn Guo
2022-10-23 21:46     ` Marcel Ziswiler
2022-09-22 16:29 ` [PATCH v1 7/8] arm64: defconfig: enable snvs lpgpr support Marcel Ziswiler
2022-10-23 13:15   ` Shawn Guo
2022-09-22 16:29 ` [PATCH v1 8/8] arm64: defconfig: enable i.mx 8m plus specific interconnect support Marcel Ziswiler
2022-10-23 13:15   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69449ded99d51315e0a8133239dcdaa4d1547168.camel@toradex.com \
    --to=marcel.ziswiler@toradex.com \
    --cc=andrejs.cainikovs@toradex.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.krummenacher@toradex.com \
    --cc=philippe.schenker@toradex.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox