public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] iommu/vt-d: Fix lockdep splat in intel_iommu_init()
@ 2022-09-27  5:31 Lu Baolu
  2022-09-27  5:31 ` [PATCH 1/2] iommu: Add gfp parameter to iommu_alloc_resv_region Lu Baolu
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Lu Baolu @ 2022-09-27  5:31 UTC (permalink / raw)
  To: Joerg Roedel, Kevin Tian, Will Deacon, Robin Murphy
  Cc: iommu, linux-kernel, Lu Baolu

Hi folks,

As commit c919739ce472 ("iommu/vt-d: Handle race between registration
and device probe") highlights, a lockdep splat issue happens after
moving iommu probing device process into iommu_device_register().

This is due to a conflict that get_resv_regions wants hold the
dmar_global_lock, but it's also possible to be called from within a
section where intel_iommu_init() already holds the lock.

Historically, before commit 5f64ce5411b46 ("iommu/vt-d: Duplicate
iommu_resv_region objects per device list"), the rcu_lock is used in
get_resv_regions. This commit converted it to dmar_global_lock in order
to allowing sleeping in iommu_alloc_resv_region().

This aims to fix the lockdep issue by making iommu_alloc_resv_region()
available in critical section and rolling dmar_global_lock back to rcu
lock in get_resv_regions of the Intel IOMMU driver.

Best regards,
baolu

Lu Baolu (2):
  iommu: Add gfp parameter to iommu_alloc_resv_region
  iommu/vt-d: Use rcu_lock in get_resv_regions

 include/linux/iommu.h                       |  2 +-
 drivers/acpi/arm64/iort.c                   |  3 ++-
 drivers/iommu/amd/iommu.c                   |  7 ++++---
 drivers/iommu/apple-dart.c                  |  2 +-
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |  2 +-
 drivers/iommu/arm/arm-smmu/arm-smmu.c       |  2 +-
 drivers/iommu/intel/iommu.c                 | 12 +++++++-----
 drivers/iommu/iommu.c                       |  7 ++++---
 drivers/iommu/mtk_iommu.c                   |  3 ++-
 drivers/iommu/virtio-iommu.c                |  9 ++++++---
 10 files changed, 29 insertions(+), 20 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-10-19  0:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-27  5:31 [PATCH 0/2] iommu/vt-d: Fix lockdep splat in intel_iommu_init() Lu Baolu
2022-09-27  5:31 ` [PATCH 1/2] iommu: Add gfp parameter to iommu_alloc_resv_region Lu Baolu
2022-09-27  5:31 ` [PATCH 2/2] iommu/vt-d: Use rcu_lock in get_resv_regions Lu Baolu
2022-09-30  2:23 ` [PATCH 0/2] iommu/vt-d: Fix lockdep splat in intel_iommu_init() Baolu Lu
2022-10-18 21:57 ` Alex Williamson
2022-10-19  0:49 ` Baolu Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox