* [PATCH v3] thermal: imx8mm_thermal: validate temperature range
@ 2022-10-14 7:35 Marcus Folkesson
2022-10-14 7:56 ` Jacky Bai
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marcus Folkesson @ 2022-10-14 7:35 UTC (permalink / raw)
To: Rafael J . Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Anson Huang
Cc: linux-pm, linux-arm-kernel, linux-kernel, Marcus Folkesson
Check against the upper temperature limit (125 degrees C) before
consider the temperature valid.
Fixes: 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
Notes:
v2: Also invalidate if temperature > max (125 degrees C)
v3: Only check temperature range as the valid bit is invalid.
drivers/thermal/imx8mm_thermal.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
index af666bd9e8d4..c5cd873c6e01 100644
--- a/drivers/thermal/imx8mm_thermal.c
+++ b/drivers/thermal/imx8mm_thermal.c
@@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)
u32 val;
val = readl_relaxed(tmu->base + TRITSR) & TRITSR_TEMP0_VAL_MASK;
+
+ /*
+ * Do not validate against the V bit (bit 31) due to errata
+ * ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid
+ */
+
*temp = val * 1000;
- if (*temp < VER1_TEMP_LOW_LIMIT)
+ if (*temp < VER1_TEMP_LOW_LIMIT || *temp > VER2_TEMP_HIGH_LIMIT)
return -EAGAIN;
return 0;
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH v3] thermal: imx8mm_thermal: validate temperature range
2022-10-14 7:35 [PATCH v3] thermal: imx8mm_thermal: validate temperature range Marcus Folkesson
@ 2022-10-14 7:56 ` Jacky Bai
2022-10-17 7:25 ` Daniel Lezcano
2022-10-17 8:06 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Jacky Bai @ 2022-10-14 7:56 UTC (permalink / raw)
To: Marcus Folkesson, Rafael J . Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, Anson Huang
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]
> Subject: [PATCH v3] thermal: imx8mm_thermal: validate temperature range
>
> Check against the upper temperature limit (125 degrees C) before consider
> the temperature valid.
>
> Fixes: 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal
> monitoring unit")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>
> Notes:
> v2: Also invalidate if temperature > max (125 degrees C)
> v3: Only check temperature range as the valid bit is invalid.
>
> drivers/thermal/imx8mm_thermal.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c
> b/drivers/thermal/imx8mm_thermal.c
> index af666bd9e8d4..c5cd873c6e01 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int
> *temp)
> u32 val;
>
> val = readl_relaxed(tmu->base + TRITSR) & TRITSR_TEMP0_VAL_MASK;
> +
> + /*
> + * Do not validate against the V bit (bit 31) due to errata
> + * ERR051272: TMU: Bit 31 of registers
> TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid
> + */
> +
> *temp = val * 1000;
> - if (*temp < VER1_TEMP_LOW_LIMIT)
> + if (*temp < VER1_TEMP_LOW_LIMIT || *temp >
> VER2_TEMP_HIGH_LIMIT)
Don't remember the reason why I only add low limit check before. Should be
ok to check the high limit.
Reviewed-by: Jacky Bai <ping.bai@nxp.com>
BR
> return -EAGAIN;
>
> return 0;
> --
> 2.37.1
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 9646 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] thermal: imx8mm_thermal: validate temperature range
2022-10-14 7:35 [PATCH v3] thermal: imx8mm_thermal: validate temperature range Marcus Folkesson
2022-10-14 7:56 ` Jacky Bai
@ 2022-10-17 7:25 ` Daniel Lezcano
2022-10-17 8:06 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2022-10-17 7:25 UTC (permalink / raw)
To: Marcus Folkesson, Rafael J . Wysocki, Amit Kucheria, Zhang Rui,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Anson Huang
Cc: linux-pm, linux-arm-kernel, linux-kernel
On 14/10/2022 09:35, Marcus Folkesson wrote:
> Check against the upper temperature limit (125 degrees C) before
> consider the temperature valid.
>
> Fixes: 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] thermal: imx8mm_thermal: validate temperature range
2022-10-14 7:35 [PATCH v3] thermal: imx8mm_thermal: validate temperature range Marcus Folkesson
2022-10-14 7:56 ` Jacky Bai
2022-10-17 7:25 ` Daniel Lezcano
@ 2022-10-17 8:06 ` Peng Fan
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2022-10-17 8:06 UTC (permalink / raw)
To: Marcus Folkesson, Rafael J . Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Anson Huang
Cc: linux-pm, linux-arm-kernel, linux-kernel
On 10/14/2022 3:35 PM, Marcus Folkesson wrote:
> Check against the upper temperature limit (125 degrees C) before
> consider the temperature valid.
>
> Fixes: 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>
> Notes:
> v2: Also invalidate if temperature > max (125 degrees C)
> v3: Only check temperature range as the valid bit is invalid.
>
> drivers/thermal/imx8mm_thermal.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index af666bd9e8d4..c5cd873c6e01 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)
> u32 val;
>
> val = readl_relaxed(tmu->base + TRITSR) & TRITSR_TEMP0_VAL_MASK;
> +
> + /*
> + * Do not validate against the V bit (bit 31) due to errata
> + * ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid
> + */
> +
> *temp = val * 1000;
> - if (*temp < VER1_TEMP_LOW_LIMIT)
> + if (*temp < VER1_TEMP_LOW_LIMIT || *temp > VER2_TEMP_HIGH_LIMIT)
> return -EAGAIN;
>
> return 0;
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-17 8:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-14 7:35 [PATCH v3] thermal: imx8mm_thermal: validate temperature range Marcus Folkesson
2022-10-14 7:56 ` Jacky Bai
2022-10-17 7:25 ` Daniel Lezcano
2022-10-17 8:06 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox