From: Guenter Roeck <linux@roeck-us.net>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 4/4] hwmon: (jc42) Don't cache the temperature register
Date: Thu, 20 Oct 2022 15:14:17 -0700 [thread overview]
Message-ID: <20221020221417.GG4035307@roeck-us.net> (raw)
In-Reply-To: <20221020210320.1624617-5-martin.blumenstingl@googlemail.com>
On Thu, Oct 20, 2022 at 11:03:20PM +0200, Martin Blumenstingl wrote:
> Now that we're utilizing regmap and it's regcache for the
> minimum/maximum/critical temperature registers the only cached register
> that's left is the actual temperature register. Drop the custom cache
> implementation as it just complicates things.
>
Ah, you got there eventually. Just combine this patch into the first
patch of the series. No need to keep separate patches, especially since
a lot of the code changed in patch 1 and 2 is just thrown away here.
That reminds me, though: Make sure that the alarm bits are not dropped
after reading the temperature (running the 'sensors' command with
alarms active should do). I have some JC42 chips here and will do the
same.
Thanks,
Guenter
next prev parent reply other threads:[~2022-10-20 22:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 21:03 [RFC PATCH v2 0/4] hwmon: (jc42) regmap conversion and resume fix Martin Blumenstingl
2022-10-20 21:03 ` [RFC PATCH v2 1/4] hwmon: (jc42) Convert register access to use an I2C regmap Martin Blumenstingl
2022-10-20 22:07 ` Guenter Roeck
2022-10-20 21:03 ` [RFC PATCH v2 2/4] hwmon: (jc42) Convert to regmap's built-in caching Martin Blumenstingl
2022-10-20 22:04 ` Guenter Roeck
2022-10-20 21:03 ` [RFC PATCH v2 3/4] hwmon: (jc42) Restore the min/max/critical temperatures on resume Martin Blumenstingl
2022-10-20 21:03 ` [RFC PATCH v2 4/4] hwmon: (jc42) Don't cache the temperature register Martin Blumenstingl
2022-10-20 22:14 ` Guenter Roeck [this message]
2022-10-20 22:22 ` Martin Blumenstingl
2022-10-20 22:37 ` Guenter Roeck
2022-10-20 22:16 ` [RFC PATCH v2 0/4] hwmon: (jc42) regmap conversion and resume fix Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020221417.GG4035307@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox