From: Guenter Roeck <linux@roeck-us.net>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/4] hwmon: (jc42) regmap conversion and resume fix
Date: Thu, 20 Oct 2022 15:16:45 -0700 [thread overview]
Message-ID: <20221020221645.GH4035307@roeck-us.net> (raw)
In-Reply-To: <20221020210320.1624617-1-martin.blumenstingl@googlemail.com>
On Thu, Oct 20, 2022 at 11:03:16PM +0200, Martin Blumenstingl wrote:
> Hello,
>
> this is a follow-up to the comments I got from Guenter on v1 of my patch
> from [0] titled:
> "hwmon: (jc42) Restore the min/max/critical temperatures on resume"
> There Guenter suggested: "The best solution would probably be to convert
> the driver to use regmap and let regmap handle the caching". That's the
> goal of this series - in addition to fixing the original resume issue
> (see patch #3 - which was the reason for v1 of this series).
>
> Changes since v1 at [0]:
> - marked as RFC
> - added patches for regmap (patch #1) and regcache (patch #2) conversion
> - patch #3 has been updated to use regcache for restoring the register
> values during system resume (this was originally patch 1/1)
> - added another patch to remove caching of the temperature register
>
Great, excellent work. As mentioned in the patches, please combine
patches 1, 2, and 4 into a single patch. Also, drop the RFC.
Thanks,
Guenter
prev parent reply other threads:[~2022-10-20 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 21:03 [RFC PATCH v2 0/4] hwmon: (jc42) regmap conversion and resume fix Martin Blumenstingl
2022-10-20 21:03 ` [RFC PATCH v2 1/4] hwmon: (jc42) Convert register access to use an I2C regmap Martin Blumenstingl
2022-10-20 22:07 ` Guenter Roeck
2022-10-20 21:03 ` [RFC PATCH v2 2/4] hwmon: (jc42) Convert to regmap's built-in caching Martin Blumenstingl
2022-10-20 22:04 ` Guenter Roeck
2022-10-20 21:03 ` [RFC PATCH v2 3/4] hwmon: (jc42) Restore the min/max/critical temperatures on resume Martin Blumenstingl
2022-10-20 21:03 ` [RFC PATCH v2 4/4] hwmon: (jc42) Don't cache the temperature register Martin Blumenstingl
2022-10-20 22:14 ` Guenter Roeck
2022-10-20 22:22 ` Martin Blumenstingl
2022-10-20 22:37 ` Guenter Roeck
2022-10-20 22:16 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020221645.GH4035307@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox