* [PATCH] speakup: include types.h so u_char is a known type
@ 2022-10-25 10:18 Eric Curtin
2022-10-25 10:48 ` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Eric Curtin @ 2022-10-25 10:18 UTC (permalink / raw)
To: gregkh
Cc: Eric Curtin, William Hubbs, Chris Brannon, Kirk Reiser,
Samuel Thibault, open list:SPEAKUP CONSOLE SPEECH DRIVER,
open list
Fixes build of utils.h header file, occurred when building kernel on
postmarketOS on Lenovo Duet Chromebook.
drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?
57 | u_char *pn = (u_char *)name;
| ^~~~~~
| char
Fixes: 6a5c94d92699 ("speakup: Generate speakupmap.h automatically")
Signed-off-by: Eric Curtin <ecurtin@redhat.com>
---
drivers/accessibility/speakup/utils.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..f6fe477ecb28 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -7,6 +7,7 @@
*/
#include <stdio.h>
+#include <sys/types.h>
#define MAXKEYS 512
#define MAXKEYVAL 160
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] speakup: include types.h so u_char is a known type
2022-10-25 10:18 [PATCH] speakup: include types.h so u_char is a known type Eric Curtin
@ 2022-10-25 10:48 ` Samuel Thibault
2022-10-25 11:08 ` Eric Curtin
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ 2022-10-25 10:48 UTC (permalink / raw)
To: Eric Curtin
Cc: gregkh, William Hubbs, Chris Brannon, Kirk Reiser,
open list:SPEAKUP CONSOLE SPEECH DRIVER, open list
Hello,
Eric Curtin, le mar. 25 oct. 2022 11:18:24 +0100, a ecrit:
> Fixes build of utils.h header file, occurred when building kernel on
> postmarketOS on Lenovo Duet Chromebook.
>
> drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?
> 57 | u_char *pn = (u_char *)name;
> | ^~~~~~
> | char
>
There is already a patch pending commit that just replaces it with
unsigned char.
(see
Subject: [PATCH] speakup: replace utils' u_char with unsigned char
)
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] speakup: include types.h so u_char is a known type
2022-10-25 10:48 ` Samuel Thibault
@ 2022-10-25 11:08 ` Eric Curtin
0 siblings, 0 replies; 3+ messages in thread
From: Eric Curtin @ 2022-10-25 11:08 UTC (permalink / raw)
To: Samuel Thibault, Eric Curtin, gregkh, William Hubbs,
Chris Brannon, Kirk Reiser,
open list:SPEAKUP CONSOLE SPEECH DRIVER, open list
On Tue, 25 Oct 2022 at 11:54, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
>
> Hello,
>
> Eric Curtin, le mar. 25 oct. 2022 11:18:24 +0100, a ecrit:
> > Fixes build of utils.h header file, occurred when building kernel on
> > postmarketOS on Lenovo Duet Chromebook.
> >
> > drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?
> > 57 | u_char *pn = (u_char *)name;
> > | ^~~~~~
> > | char
> >
>
> There is already a patch pending commit that just replaces it with
> unsigned char.
Sorry I missed that. that works for me :)
>
> (see
> Subject: [PATCH] speakup: replace utils' u_char with unsigned char
> )
>
> Samuel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-25 11:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-25 10:18 [PATCH] speakup: include types.h so u_char is a known type Eric Curtin
2022-10-25 10:48 ` Samuel Thibault
2022-10-25 11:08 ` Eric Curtin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox