From: Mitja Spes <mitja@lxnav.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Mitja Spes <mitja@lxnav.com>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] iio: adc: mcp3422: fix scale read bug
Date: Fri, 11 Nov 2022 12:26:53 +0100 [thread overview]
Message-ID: <20221111112657.1521307-2-mitja@lxnav.com> (raw)
In-Reply-To: <20221111112657.1521307-1-mitja@lxnav.com>
Scale was returned for currently active channel instead of the specified
channel.
Signed-off-by: Mitja Spes <mitja@lxnav.com>
Fixes: 07914c84ba30 ("iio: adc: Add driver for Microchip MCP3422/3/4 high resolution ADC")
---
drivers/iio/adc/mcp3422.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
index da353dcb1e9d..3d53de300c89 100644
--- a/drivers/iio/adc/mcp3422.c
+++ b/drivers/iio/adc/mcp3422.c
@@ -164,8 +164,9 @@ static int mcp3422_read_raw(struct iio_dev *iio,
struct mcp3422 *adc = iio_priv(iio);
int err;
+ u8 req_channel = channel->channel;
u8 sample_rate = MCP3422_SAMPLE_RATE(adc->config);
- u8 pga = MCP3422_PGA(adc->config);
+ u8 pga = adc->pga[req_channel];
switch (mask) {
case IIO_CHAN_INFO_RAW:
@@ -175,7 +176,6 @@ static int mcp3422_read_raw(struct iio_dev *iio,
return IIO_VAL_INT;
case IIO_CHAN_INFO_SCALE:
-
*val1 = 0;
*val2 = mcp3422_scales[sample_rate][pga];
return IIO_VAL_INT_PLUS_NANO;
--
2.34.1
next prev parent reply other threads:[~2022-11-11 11:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 11:26 [PATCH 0/4] iio: adc: mcp3422 improvements Mitja Spes
2022-11-11 11:26 ` Mitja Spes [this message]
2022-11-12 17:10 ` [PATCH 1/4] iio: adc: mcp3422: fix scale read bug Jonathan Cameron
2022-11-12 20:06 ` Mitja Špes
2022-11-11 11:26 ` [PATCH 2/4] iio: adc: mcp3422: allow setting gain and sampling per channel Mitja Spes
2022-11-12 17:28 ` Jonathan Cameron
2022-11-12 20:51 ` Mitja Špes
2022-11-13 12:06 ` Jonathan Cameron
2022-11-13 13:39 ` Mitja Špes
2022-11-14 20:18 ` Jonathan Cameron
2022-11-11 11:26 ` [PATCH 3/4] iio: adc: mcp3422: add hardware gain attribute Mitja Spes
2022-11-12 17:32 ` Jonathan Cameron
2022-11-12 21:19 ` Mitja Špes
2022-11-13 12:33 ` Jonathan Cameron
2022-11-13 13:51 ` Mitja Špes
2022-11-11 11:26 ` [PATCH 4/4] iio: adc: mcp3422: reduce sleep for fast sampling rates Mitja Spes
2022-11-12 17:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111112657.1521307-2-mitja@lxnav.com \
--to=mitja@lxnav.com \
--cc=angelo.compagnucci@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox