From: Mitja Spes <mitja@lxnav.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Mitja Spes <mitja@lxnav.com>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] iio: adc: mcp3422: add hardware gain attribute
Date: Fri, 11 Nov 2022 12:26:55 +0100 [thread overview]
Message-ID: <20221111112657.1521307-4-mitja@lxnav.com> (raw)
In-Reply-To: <20221111112657.1521307-1-mitja@lxnav.com>
Allows setting gain separately from scale.
Signed-off-by: Mitja Spes <mitja@lxnav.com>
---
drivers/iio/adc/mcp3422.c | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
index cfb629b964af..eef35fb2fc22 100644
--- a/drivers/iio/adc/mcp3422.c
+++ b/drivers/iio/adc/mcp3422.c
@@ -58,7 +58,8 @@
.channel = _index, \
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) \
| BIT(IIO_CHAN_INFO_SCALE) \
- | BIT(IIO_CHAN_INFO_SAMP_FREQ), \
+ | BIT(IIO_CHAN_INFO_SAMP_FREQ) \
+ | BIT(IIO_CHAN_INFO_HARDWAREGAIN), \
}
static const int mcp3422_scales[MCP3422_SRATE_COUNT][MCP3422_PGA_COUNT] = {
@@ -184,6 +185,10 @@ static int mcp3422_read_raw(struct iio_dev *iio,
*val1 = mcp3422_sample_rates[sample_rate];
return IIO_VAL_INT;
+ case IIO_CHAN_INFO_HARDWAREGAIN:
+ *val1 = (1 << pga);
+ return IIO_VAL_INT;
+
default:
break;
}
@@ -245,6 +250,29 @@ static int mcp3422_write_raw(struct iio_dev *iio,
adc->ch_config[req_channel] = config;
return 0;
+ case IIO_CHAN_INFO_HARDWAREGAIN:
+ switch (val1) {
+ case 1:
+ temp = MCP3422_PGA_1;
+ break;
+ case 2:
+ temp = MCP3422_PGA_2;
+ break;
+ case 4:
+ temp = MCP3422_PGA_4;
+ break;
+ case 8:
+ temp = MCP3422_PGA_8;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ config &= ~MCP3422_PGA_MASK;
+ config |= MCP3422_PGA_VALUE(temp);
+ adc->ch_config[req_channel] = config;
+ return 0;
+
default:
break;
}
@@ -260,6 +288,8 @@ static int mcp3422_write_raw_get_fmt(struct iio_dev *indio_dev,
return IIO_VAL_INT_PLUS_NANO;
case IIO_CHAN_INFO_SAMP_FREQ:
return IIO_VAL_INT_PLUS_MICRO;
+ case IIO_CHAN_INFO_HARDWAREGAIN:
+ return IIO_VAL_INT_PLUS_MICRO;
default:
return -EINVAL;
}
--
2.34.1
next prev parent reply other threads:[~2022-11-11 11:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 11:26 [PATCH 0/4] iio: adc: mcp3422 improvements Mitja Spes
2022-11-11 11:26 ` [PATCH 1/4] iio: adc: mcp3422: fix scale read bug Mitja Spes
2022-11-12 17:10 ` Jonathan Cameron
2022-11-12 20:06 ` Mitja Špes
2022-11-11 11:26 ` [PATCH 2/4] iio: adc: mcp3422: allow setting gain and sampling per channel Mitja Spes
2022-11-12 17:28 ` Jonathan Cameron
2022-11-12 20:51 ` Mitja Špes
2022-11-13 12:06 ` Jonathan Cameron
2022-11-13 13:39 ` Mitja Špes
2022-11-14 20:18 ` Jonathan Cameron
2022-11-11 11:26 ` Mitja Spes [this message]
2022-11-12 17:32 ` [PATCH 3/4] iio: adc: mcp3422: add hardware gain attribute Jonathan Cameron
2022-11-12 21:19 ` Mitja Špes
2022-11-13 12:33 ` Jonathan Cameron
2022-11-13 13:51 ` Mitja Špes
2022-11-11 11:26 ` [PATCH 4/4] iio: adc: mcp3422: reduce sleep for fast sampling rates Mitja Spes
2022-11-12 17:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111112657.1521307-4-mitja@lxnav.com \
--to=mitja@lxnav.com \
--cc=angelo.compagnucci@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox