* [PATCH] btrfs: avoid use-after-free when return the error code
@ 2022-11-23 14:39 void0red
2022-11-23 15:40 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: void0red @ 2022-11-23 14:39 UTC (permalink / raw)
To: dsterba; +Cc: linux-btrfs, linux-kernel, void0red, eriri
free_extent_map(em) will free em->map_lookup, so it is
wrong to use it when return.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216721
Signed-off-by: void0red <void0red@gmail.com>
Reported-by: eriri <1527030098@qq.com>
---
fs/btrfs/volumes.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 635f45f1a2ef..dba087ad40ea 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -7241,8 +7241,9 @@ static int read_one_chunk(struct btrfs_key *key, struct extent_buffer *leaf,
map->stripes[i].dev = handle_missing_device(fs_info,
devid, uuid);
if (IS_ERR(map->stripes[i].dev)) {
+ ret = PTR_ERR(map->stripes[i].dev);
free_extent_map(em);
- return PTR_ERR(map->stripes[i].dev);
+ return ret;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: avoid use-after-free when return the error code
2022-11-23 14:39 [PATCH] btrfs: avoid use-after-free when return the error code void0red
@ 2022-11-23 15:40 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2022-11-23 15:40 UTC (permalink / raw)
To: void0red; +Cc: dsterba, linux-btrfs, linux-kernel, eriri
On Wed, Nov 23, 2022 at 10:39:45PM +0800, void0red wrote:
> free_extent_map(em) will free em->map_lookup, so it is
> wrong to use it when return.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216721
> Signed-off-by: void0red <void0red@gmail.com>
> Reported-by: eriri <1527030098@qq.com>
Added to misc-next with updated changelog, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-23 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-23 14:39 [PATCH] btrfs: avoid use-after-free when return the error code void0red
2022-11-23 15:40 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox