* [PATCH linux-next] drm/virtio: use strscpy() to instead of strncpy()
@ 2022-12-07 1:13 yang.yang29
2023-02-27 0:04 ` Dmitry Osipenko
0 siblings, 1 reply; 2+ messages in thread
From: yang.yang29 @ 2022-12-07 1:13 UTC (permalink / raw)
To: airlied
Cc: kraxel, gurchetansingh, olvaffe, daniel, dri-devel,
virtualization, linux-kernel, xu.panda, yang.yang29
From: Xu Panda <xu.panda@zte.com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 9ff8660b50ad..7d95bc74b307 100644
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
@@ -916,8 +916,7 @@ void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id,
cmd_p->hdr.ctx_id = cpu_to_le32(id);
cmd_p->nlen = cpu_to_le32(nlen);
cmd_p->context_init = cpu_to_le32(context_init);
- strncpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name) - 1);
- cmd_p->debug_name[sizeof(cmd_p->debug_name) - 1] = 0;
+ strscpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name));
virtio_gpu_queue_ctrl_buffer(vgdev, vbuf);
}
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] drm/virtio: use strscpy() to instead of strncpy()
2022-12-07 1:13 [PATCH linux-next] drm/virtio: use strscpy() to instead of strncpy() yang.yang29
@ 2023-02-27 0:04 ` Dmitry Osipenko
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Osipenko @ 2023-02-27 0:04 UTC (permalink / raw)
To: yang.yang29, airlied
Cc: xu.panda, linux-kernel, dri-devel, virtualization, kraxel,
gurchetansingh
On 12/7/22 04:13, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 9ff8660b50ad..7d95bc74b307 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -916,8 +916,7 @@ void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id,
> cmd_p->hdr.ctx_id = cpu_to_le32(id);
> cmd_p->nlen = cpu_to_le32(nlen);
> cmd_p->context_init = cpu_to_le32(context_init);
> - strncpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name) - 1);
> - cmd_p->debug_name[sizeof(cmd_p->debug_name) - 1] = 0;
> + strscpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name));
> virtio_gpu_queue_ctrl_buffer(vgdev, vbuf);
> }
>
Applied to misc-next
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-27 0:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 1:13 [PATCH linux-next] drm/virtio: use strscpy() to instead of strncpy() yang.yang29
2023-02-27 0:04 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox