* [PATCH -next] media: v4l2-ctrls: clean up some inconsistent indentings
@ 2022-12-16 7:42 Yang Li
2023-01-27 8:36 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-12-16 7:42 UTC (permalink / raw)
To: mchehab; +Cc: linux-media, linux-kernel, Yang Li, Abaci Robot
clean up some inconsistent indentings to improve the readability of the
code.
drivers/media/v4l2-core/v4l2-ctrls-api.c:154 user_to_new() warn: inconsistent indenting
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3503
Fixes: 73278d483378 ("media: v4l2-ctrls-api.c: add back dropped ctrl->is_new = 1")
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/media/v4l2-core/v4l2-ctrls-api.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls-api.c b/drivers/media/v4l2-core/v4l2-ctrls-api.c
index 3d3b6dc24ca6..3bee4ad5be7c 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls-api.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-api.c
@@ -150,8 +150,8 @@ static int user_to_new(struct v4l2_ext_control *c, struct v4l2_ctrl *ctrl)
* then return an error.
*/
if (strlen(ctrl->p_new.p_char) == ctrl->maximum && last)
- ctrl->is_new = 1;
- return -ERANGE;
+ ctrl->is_new = 1;
+ return -ERANGE;
}
return ret;
default:
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] media: v4l2-ctrls: clean up some inconsistent indentings
2022-12-16 7:42 [PATCH -next] media: v4l2-ctrls: clean up some inconsistent indentings Yang Li
@ 2023-01-27 8:36 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2023-01-27 8:36 UTC (permalink / raw)
To: Yang Li, mchehab; +Cc: linux-media, linux-kernel, Abaci Robot
On 16/12/2022 08:42, Yang Li wrote:
> clean up some inconsistent indentings to improve the readability of the
> code.
>
> drivers/media/v4l2-core/v4l2-ctrls-api.c:154 user_to_new() warn: inconsistent indenting
Thank you for the patch, but the actual fix is already on its way
to mainline:
https://patchwork.linuxtv.org/project/linux-media/patch/69624c54-7cbd-7362-c468-f8ffea9614be@xs4all.nl/
Rejecting this in patchwork.
Regards,
Hans
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3503
> Fixes: 73278d483378 ("media: v4l2-ctrls-api.c: add back dropped ctrl->is_new = 1")
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/media/v4l2-core/v4l2-ctrls-api.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-api.c b/drivers/media/v4l2-core/v4l2-ctrls-api.c
> index 3d3b6dc24ca6..3bee4ad5be7c 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls-api.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls-api.c
> @@ -150,8 +150,8 @@ static int user_to_new(struct v4l2_ext_control *c, struct v4l2_ctrl *ctrl)
> * then return an error.
> */
> if (strlen(ctrl->p_new.p_char) == ctrl->maximum && last)
> - ctrl->is_new = 1;
> - return -ERANGE;
> + ctrl->is_new = 1;
> + return -ERANGE;
> }
> return ret;
> default:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-27 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-16 7:42 [PATCH -next] media: v4l2-ctrls: clean up some inconsistent indentings Yang Li
2023-01-27 8:36 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox