* [PATCH v1 1/1] util_macros.h: Add missing insclusion
@ 2023-01-03 12:19 Andy Shevchenko
2023-01-06 2:43 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2023-01-03 12:19 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel; +Cc: Andrew Morton
The header is the direct user of definitions from the math.h,
include it.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/util_macros.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/util_macros.h b/include/linux/util_macros.h
index 72299f261b25..b641ec00be3e 100644
--- a/include/linux/util_macros.h
+++ b/include/linux/util_macros.h
@@ -2,6 +2,8 @@
#ifndef _LINUX_HELPER_MACROS_H_
#define _LINUX_HELPER_MACROS_H_
+#include <linux/math.h>
+
#define __find_closest(x, a, as, op) \
({ \
typeof(as) __fc_i, __fc_as = (as) - 1; \
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] util_macros.h: Add missing insclusion
2023-01-03 12:19 [PATCH v1 1/1] util_macros.h: Add missing insclusion Andy Shevchenko
@ 2023-01-06 2:43 ` Andrew Morton
2023-01-09 10:33 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2023-01-06 2:43 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel
On Tue, 3 Jan 2023 14:19:37 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> The header is the direct user of definitions from the math.h,
> include it.
>
> ...
>
> --- a/include/linux/util_macros.h
> +++ b/include/linux/util_macros.h
> @@ -2,6 +2,8 @@
> #ifndef _LINUX_HELPER_MACROS_H_
> #define _LINUX_HELPER_MACROS_H_
>
> +#include <linux/math.h>
> +
> #define __find_closest(x, a, as, op) \
> ({ \
> typeof(as) __fc_i, __fc_as = (as) - 1; \
Does this fix any known build errors, or was it an I-noticed-this thing?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] util_macros.h: Add missing insclusion
2023-01-06 2:43 ` Andrew Morton
@ 2023-01-09 10:33 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-01-09 10:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Thu, Jan 05, 2023 at 06:43:54PM -0800, Andrew Morton wrote:
> On Tue, 3 Jan 2023 14:19:37 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> Does this fix any known build errors, or was it an I-noticed-this thing?
Not for my knowledge. It's rather the latter category to prevent such due
to header changes.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-09 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-03 12:19 [PATCH v1 1/1] util_macros.h: Add missing insclusion Andy Shevchenko
2023-01-06 2:43 ` Andrew Morton
2023-01-09 10:33 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox