From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Johan Hovold" <johan@kernel.org>,
"Samuel Iglesias Gonsálvez" <siglesias@igalia.com>,
"Rodolfo Giometti" <giometti@enneenne.com>,
linux-kernel@vger.kernel.org
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v3 04/13] tty: moxa: Make local var storing tty_port_initialized() bool
Date: Wed, 11 Jan 2023 16:23:22 +0200 [thread overview]
Message-ID: <20230111142331.34518-5-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230111142331.34518-1-ilpo.jarvinen@linux.intel.com>
Return type of tty_port_initialized() is bool, use matching type for
the local variable.
Also reorder the local vars to reverse-xmas-tree while at it.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/tty/moxa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
index bc474f3c3f8f..2d9635e14ded 100644
--- a/drivers/tty/moxa.c
+++ b/drivers/tty/moxa.c
@@ -1664,8 +1664,8 @@ static int moxa_poll_port(struct moxa_port *p, unsigned int handle,
u16 __iomem *ip)
{
struct tty_struct *tty = tty_port_tty_get(&p->port);
+ bool inited = tty_port_initialized(&p->port);
void __iomem *ofsAddr;
- unsigned int inited = tty_port_initialized(&p->port);
u16 intr;
if (tty) {
--
2.30.2
next prev parent reply other threads:[~2023-01-11 14:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 14:23 [PATCH v3 00/13] tty/serial: bool conversions and cleanups Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 01/13] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 02/13] tty: Cleamup tty_port_set_suspended() " Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 03/13] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-11 14:23 ` Ilpo Järvinen [this message]
2023-01-11 14:23 ` [PATCH v3 05/13] serial: Convert uart_{,port_}startup() init_hw param to bool Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 06/13] tty: Convert ->carrier_raised() and callchains " Ilpo Järvinen
2023-01-11 17:25 ` Johan Hovold
2023-01-13 11:50 ` Ulf Hansson
2023-01-11 14:23 ` [PATCH v3 07/13] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-11 17:26 ` Johan Hovold
2023-01-13 11:50 ` Ulf Hansson
2023-01-11 14:23 ` [PATCH v3 08/13] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Ilpo Järvinen
2023-01-11 17:27 ` Johan Hovold
2023-01-11 14:23 ` [PATCH v3 09/13] serial: Make uart_handle_cts_change() status param " Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 10/13] tty: Return bool from tty_termios_hw_change() Ilpo Järvinen
2023-01-11 17:29 ` Johan Hovold
2023-01-11 14:23 ` [PATCH v3 11/13] tty/serial: Call ->dtr_rts() parameter active consistently Ilpo Järvinen
2023-01-11 16:54 ` Johan Hovold
2023-01-13 11:49 ` Ulf Hansson
2023-01-11 14:23 ` [PATCH v3 12/13] tty: moxa: Rename dtr/rts parameters/variables to active Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 13/13] usb/serial: " Ilpo Järvinen
2023-01-11 17:00 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111142331.34518-5-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox