From: Johan Hovold <johan@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Samuel Iglesias Gonsálvez" <siglesias@igalia.com>,
"Rodolfo Giometti" <giometti@enneenne.com>,
"Oliver Neukum" <oneukum@suse.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 13/13] usb/serial: Rename dtr/rts parameters/variables to active
Date: Wed, 11 Jan 2023 18:00:25 +0100 [thread overview]
Message-ID: <Y77rKQfIYyiPwz3S@hovoldconsulting.com> (raw)
In-Reply-To: <20230111142331.34518-14-ilpo.jarvinen@linux.intel.com>
On Wed, Jan 11, 2023 at 04:23:31PM +0200, Ilpo Järvinen wrote:
> Use active consistently for naming parameters and variables.
> This converts all USB serial drivers + CDC-ACM.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/usb/class/cdc-acm.c | 4 ++--
> drivers/usb/serial/ch341.c | 4 ++--
> drivers/usb/serial/cp210x.c | 6 +++---
> drivers/usb/serial/cypress_m8.c | 6 +++---
> drivers/usb/serial/digi_acceleport.c | 6 +++---
> drivers/usb/serial/f81232.c | 4 ++--
> drivers/usb/serial/f81534.c | 4 ++--
> drivers/usb/serial/ftdi_sio.c | 6 +++---
> drivers/usb/serial/ipw.c | 8 ++++----
> drivers/usb/serial/keyspan.c | 6 +++---
> drivers/usb/serial/keyspan_pda.c | 4 ++--
> drivers/usb/serial/mct_u232.c | 6 +++---
> drivers/usb/serial/mxuport.c | 4 ++--
> drivers/usb/serial/pl2303.c | 4 ++--
> drivers/usb/serial/quatech2.c | 6 +++---
> drivers/usb/serial/sierra.c | 6 +++---
> drivers/usb/serial/spcp8x5.c | 4 ++--
> drivers/usb/serial/ssu100.c | 6 +++---
> drivers/usb/serial/upd78f0730.c | 4 ++--
> drivers/usb/serial/usb-serial.c | 4 ++--
> drivers/usb/serial/usb-wwan.h | 2 +-
> drivers/usb/serial/usb_wwan.c | 6 +++---
> drivers/usb/serial/xr_serial.c | 4 ++--
> 23 files changed, 57 insertions(+), 57 deletions(-)
You should split this up as CDC-ACM is not a USB serial driver.
But this all seem like unnecessary churn to me. It was one thing
changing the parameter name in drivers that used something ambiguous
like 'on_off' but 'on' is just as clear as 'active' (and its shorter
too).
So please drop at least the USB serial changes as all drivers already
use 'on' consistently.
Johan
prev parent reply other threads:[~2023-01-11 17:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 14:23 [PATCH v3 00/13] tty/serial: bool conversions and cleanups Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 01/13] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 02/13] tty: Cleamup tty_port_set_suspended() " Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 03/13] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 04/13] tty: moxa: Make local var storing tty_port_initialized() bool Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 05/13] serial: Convert uart_{,port_}startup() init_hw param to bool Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 06/13] tty: Convert ->carrier_raised() and callchains " Ilpo Järvinen
2023-01-11 17:25 ` Johan Hovold
2023-01-13 11:50 ` Ulf Hansson
2023-01-11 14:23 ` [PATCH v3 07/13] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-11 17:26 ` Johan Hovold
2023-01-13 11:50 ` Ulf Hansson
2023-01-11 14:23 ` [PATCH v3 08/13] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Ilpo Järvinen
2023-01-11 17:27 ` Johan Hovold
2023-01-11 14:23 ` [PATCH v3 09/13] serial: Make uart_handle_cts_change() status param " Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 10/13] tty: Return bool from tty_termios_hw_change() Ilpo Järvinen
2023-01-11 17:29 ` Johan Hovold
2023-01-11 14:23 ` [PATCH v3 11/13] tty/serial: Call ->dtr_rts() parameter active consistently Ilpo Järvinen
2023-01-11 16:54 ` Johan Hovold
2023-01-13 11:49 ` Ulf Hansson
2023-01-11 14:23 ` [PATCH v3 12/13] tty: moxa: Rename dtr/rts parameters/variables to active Ilpo Järvinen
2023-01-11 14:23 ` [PATCH v3 13/13] usb/serial: " Ilpo Järvinen
2023-01-11 17:00 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y77rKQfIYyiPwz3S@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox