From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Rodolfo Giometti <giometti@enneenne.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Johan Hovold <johan@kernel.org>,
Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v4 00/12] tty/serial: bool conversions and cleanups
Date: Tue, 17 Jan 2023 11:03:46 +0200 [thread overview]
Message-ID: <20230117090358.4796-1-ilpo.jarvinen@linux.intel.com> (raw)
There are number of functions in tty/serial which have arguments or
return types that expect/behave like bool. Likely due to them existing
before bool was available, other types are used. Make conversions to
bool and cleanups.
v4:
- Removed most of the USB serial changes from this series
v3:
- moxa: Fix function signature in comment
- moxa: Rearrange comment (0: off, 1: on) removal from rename change
to bool change (effect is internal to the series)
v2:
- Call dtr/rts parameters/variables consistently "active"
- Don't chain one return statement with ||
- Don't change function signatures to >80 chars ("while at it")
- moxa: differentiated dtr and status variables
Ilpo Järvinen (12):
tty: Cleanup tty_port_set_initialized() bool parameter
tty: Cleamup tty_port_set_suspended() bool parameter
tty: Cleanup tty_port_set_active() bool parameter
tty: moxa: Make local var storing tty_port_initialized() bool
serial: Convert uart_{,port_}startup() init_hw param to bool
tty: Convert ->carrier_raised() and callchains to bool
tty: Convert ->dtr_rts() to take bool argument
tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool
active
serial: Make uart_handle_cts_change() status param bool active
tty: Return bool from tty_termios_hw_change()
tty: Call ->dtr_rts() parameter active consistently
tty: moxa: Rename dtr/rts parameters/variables to active
drivers/char/pcmcia/synclink_cs.c | 18 +++----
drivers/ipack/devices/ipoctal.c | 4 +-
drivers/mmc/core/sdio_uart.c | 13 +++--
drivers/pps/clients/pps-ldisc.c | 6 +--
drivers/s390/char/con3215.c | 4 +-
drivers/staging/greybus/uart.c | 4 +-
drivers/tty/amiserial.c | 12 ++---
drivers/tty/hvc/hvc_console.c | 4 +-
drivers/tty/hvc/hvc_console.h | 2 +-
drivers/tty/hvc/hvc_iucv.c | 6 +--
drivers/tty/moxa.c | 82 ++++++++++++++++---------------
drivers/tty/mxser.c | 11 +++--
drivers/tty/n_gsm.c | 16 +++---
drivers/tty/serial/imx.c | 2 +-
drivers/tty/serial/max3100.c | 2 +-
drivers/tty/serial/max310x.c | 3 +-
drivers/tty/serial/serial_core.c | 65 ++++++++++++------------
drivers/tty/serial/sunhv.c | 8 +--
drivers/tty/synclink_gt.c | 21 ++++----
drivers/tty/tty_ioctl.c | 8 +--
drivers/tty/tty_port.c | 22 ++++-----
drivers/usb/class/cdc-acm.c | 4 +-
drivers/usb/serial/console.c | 2 +-
drivers/usb/serial/usb-serial.c | 6 +--
include/linux/serial_core.h | 6 +--
include/linux/tty.h | 2 +-
include/linux/tty_ldisc.h | 4 +-
include/linux/tty_port.h | 10 ++--
net/bluetooth/rfcomm/tty.c | 2 +-
29 files changed, 173 insertions(+), 176 deletions(-)
--
2.30.2
next reply other threads:[~2023-01-17 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 9:03 Ilpo Järvinen [this message]
2023-01-17 9:03 ` [PATCH v4 01/12] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 02/12] tty: Cleamup tty_port_set_suspended() " Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 03/12] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 04/12] tty: moxa: Make local var storing tty_port_initialized() bool Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 05/12] serial: Convert uart_{,port_}startup() init_hw param to bool Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 06/12] tty: Convert ->carrier_raised() and callchains " Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 07/12] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 08/12] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 09/12] serial: Make uart_handle_cts_change() status param " Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 10/12] tty: Return bool from tty_termios_hw_change() Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 11/12] tty: Call ->dtr_rts() parameter active consistently Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 12/12] tty: moxa: Rename dtr/rts parameters/variables to active Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117090358.4796-1-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=siglesias@igalia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox