From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Rodolfo Giometti <giometti@enneenne.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Johan Hovold <johan@kernel.org>,
Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
linux-kernel@vger.kernel.org
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v4 05/12] serial: Convert uart_{,port_}startup() init_hw param to bool
Date: Tue, 17 Jan 2023 11:03:51 +0200 [thread overview]
Message-ID: <20230117090358.4796-6-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230117090358.4796-1-ilpo.jarvinen@linux.intel.com>
Convert init_hw parameter in uart_startup() and uart_port_startup() to
bool as code treats them like bool.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/tty/serial/serial_core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index c881fefa3d97..f7074ac02801 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -182,7 +182,7 @@ static void uart_port_dtr_rts(struct uart_port *uport, int raise)
* will be serialised by the per-port mutex.
*/
static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
- int init_hw)
+ bool init_hw)
{
struct uart_port *uport = uart_port_check(state);
unsigned long flags;
@@ -254,7 +254,7 @@ static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
}
static int uart_startup(struct tty_struct *tty, struct uart_state *state,
- int init_hw)
+ bool init_hw)
{
struct tty_port *port = &state->port;
int retval;
@@ -997,7 +997,7 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
uart_change_speed(tty, state, NULL);
}
} else {
- retval = uart_startup(tty, state, 1);
+ retval = uart_startup(tty, state, true);
if (retval == 0)
tty_port_set_initialized(port, true);
if (retval > 0)
@@ -1165,7 +1165,7 @@ static int uart_do_autoconfig(struct tty_struct *tty, struct uart_state *state)
*/
uport->ops->config_port(uport, flags);
- ret = uart_startup(tty, state, 1);
+ ret = uart_startup(tty, state, true);
if (ret == 0)
tty_port_set_initialized(port, true);
if (ret > 0)
@@ -1943,7 +1943,7 @@ static int uart_port_activate(struct tty_port *port, struct tty_struct *tty)
/*
* Start up the serial port.
*/
- ret = uart_startup(tty, state, 0);
+ ret = uart_startup(tty, state, false);
if (ret > 0)
tty_port_set_active(port, true);
--
2.30.2
next prev parent reply other threads:[~2023-01-17 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 9:03 [PATCH v4 00/12] tty/serial: bool conversions and cleanups Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 01/12] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 02/12] tty: Cleamup tty_port_set_suspended() " Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 03/12] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 04/12] tty: moxa: Make local var storing tty_port_initialized() bool Ilpo Järvinen
2023-01-17 9:03 ` Ilpo Järvinen [this message]
2023-01-17 9:03 ` [PATCH v4 06/12] tty: Convert ->carrier_raised() and callchains to bool Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 07/12] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 08/12] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 09/12] serial: Make uart_handle_cts_change() status param " Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 10/12] tty: Return bool from tty_termios_hw_change() Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 11/12] tty: Call ->dtr_rts() parameter active consistently Ilpo Järvinen
2023-01-17 9:03 ` [PATCH v4 12/12] tty: moxa: Rename dtr/rts parameters/variables to active Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117090358.4796-6-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=siglesias@igalia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox