* [PATCH v1 1/1] platform/x86: intel/pmc: Switch to use acpi_evaluate_dsm_typed()
@ 2023-01-18 9:54 Andy Shevchenko
2023-01-18 20:15 ` Rajneesh Bhardwaj
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-01-18 9:54 UTC (permalink / raw)
To: Hans de Goede, David E. Box, Gayatri Kammela, Andy Shevchenko,
platform-driver-x86, linux-kernel
Cc: Rajneesh Bhardwaj, David E Box, Mark Gross
The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/intel/pmc/tgl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel/pmc/tgl.c b/drivers/platform/x86/intel/pmc/tgl.c
index e3e50538465d..c245ada849d0 100644
--- a/drivers/platform/x86/intel/pmc/tgl.c
+++ b/drivers/platform/x86/intel/pmc/tgl.c
@@ -221,9 +221,9 @@ void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev)
guid_parse(ACPI_S0IX_DSM_UUID, &s0ix_dsm_guid);
- out_obj = acpi_evaluate_dsm(adev->handle, &s0ix_dsm_guid, 0,
- ACPI_GET_LOW_MODE_REGISTERS, NULL);
- if (out_obj && out_obj->type == ACPI_TYPE_BUFFER) {
+ out_obj = acpi_evaluate_dsm_typed(adev->handle, &s0ix_dsm_guid, 0,
+ ACPI_GET_LOW_MODE_REGISTERS, NULL, ACPI_TYPE_BUFFER);
+ if (out_obj) {
u32 size = out_obj->buffer.length;
if (size != lpm_size) {
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] platform/x86: intel/pmc: Switch to use acpi_evaluate_dsm_typed()
2023-01-18 9:54 [PATCH v1 1/1] platform/x86: intel/pmc: Switch to use acpi_evaluate_dsm_typed() Andy Shevchenko
@ 2023-01-18 20:15 ` Rajneesh Bhardwaj
0 siblings, 0 replies; 2+ messages in thread
From: Rajneesh Bhardwaj @ 2023-01-18 20:15 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Hans de Goede, David E. Box, Gayatri Kammela, platform-driver-x86,
linux-kernel, David E Box, Mark Gross
Looks good.
Reviewed-by : Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>
On Wed, Jan 18, 2023 at 4:54 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/platform/x86/intel/pmc/tgl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/tgl.c b/drivers/platform/x86/intel/pmc/tgl.c
> index e3e50538465d..c245ada849d0 100644
> --- a/drivers/platform/x86/intel/pmc/tgl.c
> +++ b/drivers/platform/x86/intel/pmc/tgl.c
> @@ -221,9 +221,9 @@ void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev)
>
> guid_parse(ACPI_S0IX_DSM_UUID, &s0ix_dsm_guid);
>
> - out_obj = acpi_evaluate_dsm(adev->handle, &s0ix_dsm_guid, 0,
> - ACPI_GET_LOW_MODE_REGISTERS, NULL);
> - if (out_obj && out_obj->type == ACPI_TYPE_BUFFER) {
> + out_obj = acpi_evaluate_dsm_typed(adev->handle, &s0ix_dsm_guid, 0,
> + ACPI_GET_LOW_MODE_REGISTERS, NULL, ACPI_TYPE_BUFFER);
> + if (out_obj) {
> u32 size = out_obj->buffer.length;
>
> if (size != lpm_size) {
> --
> 2.39.0
>
--
Thanks,
Rajneesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-18 20:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-18 9:54 [PATCH v1 1/1] platform/x86: intel/pmc: Switch to use acpi_evaluate_dsm_typed() Andy Shevchenko
2023-01-18 20:15 ` Rajneesh Bhardwaj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox