From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Subject: [PATCH 2/4] selftests/resctrl: Don't hard code divisor in MBM results
Date: Wed, 8 Feb 2023 11:40:24 +0200 [thread overview]
Message-ID: <20230208094026.22529-3-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230208094026.22529-1-ilpo.jarvinen@linux.intel.com>
From: Fenghua Yu <fenghua.yu@intel.com>
Presently, while calculating MBM results, the divisor is hard coded as 4.
It's hard coded to 4 because "NUM_OF_RUNS" is defined as 5 and the test
does not count first result and hence 4. So, instead of hard coding the
value to 4, change it to NUM_OF_RUNS - 1.
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
tools/testing/selftests/resctrl/mbm_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
index 8392e5c55ed0..4f85cbbfd037 100644
--- a/tools/testing/selftests/resctrl/mbm_test.c
+++ b/tools/testing/selftests/resctrl/mbm_test.c
@@ -31,8 +31,8 @@ show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, int span)
sum_bw_resc += bw_resc[runs];
}
- avg_bw_imc = sum_bw_imc / 4;
- avg_bw_resc = sum_bw_resc / 4;
+ avg_bw_imc = sum_bw_imc / (NUM_OF_RUNS - 1);
+ avg_bw_resc = sum_bw_resc / (NUM_OF_RUNS - 1);
avg_diff = (float)labs(avg_bw_resc - avg_bw_imc) / avg_bw_imc;
avg_diff_per = (int)(avg_diff * 100);
--
2.30.2
next prev parent reply other threads:[~2023-02-08 9:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 9:40 [PATCH 0/4] selftests/resctrl: Small cleanups Ilpo Järvinen
2023-02-08 9:40 ` [PATCH 1/4] selftests/resctrl: Change initialize_llc_perf() return type to void Ilpo Järvinen
2023-02-14 0:59 ` Reinette Chatre
2023-02-08 9:40 ` Ilpo Järvinen [this message]
2023-02-14 0:59 ` [PATCH 2/4] selftests/resctrl: Don't hard code divisor in MBM results Reinette Chatre
2023-02-14 10:00 ` Ilpo Järvinen
2023-02-14 17:01 ` Reinette Chatre
2023-02-08 9:40 ` [PATCH 3/4] selftests/resctrl: Change name from CBM_MASK_PATH to INFO_PATH Ilpo Järvinen
2023-02-08 14:04 ` Ilpo Järvinen
2023-02-14 0:59 ` Reinette Chatre
2023-02-08 9:40 ` [PATCH 4/4] selftests/resctrl: Use remount_resctrlfs() consistently with boolean Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208094026.22529-3-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox